summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSteven Luong <sluong@cisco.com>2021-11-03 16:49:04 -0700
committerSteven Luong <sluong@cisco.com>2021-11-03 16:50:20 -0700
commitb5a2b05327c1a2bbb23dbb7131cc1be6c0db5e67 (patch)
tree737ef5669fa6f611d825c9b39b81be4e3c9e5be0
parent03d0fbe3c11c8d21c347979e30b7bdcf232536aa (diff)
vppinfra: strstr_s_inline checks string unterminated wrong
When checking whether s2 is unterminated, it uses s1max. It should use s2max. Type: fix Fixes: b0598497afde60146fe8480331c9f96e7a79475a Signed-off-by: Steven Luong <sluong@cisco.com> Change-Id: I8a0b8ceebc2dd18402a87274add528c3d085a95a
-rw-r--r--src/vppinfra/string.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/vppinfra/string.h b/src/vppinfra/string.h
index 0d2c0655c50..db09c508447 100644
--- a/src/vppinfra/string.h
+++ b/src/vppinfra/string.h
@@ -1395,7 +1395,7 @@ strstr_s_inline (char *s1, rsize_t s1max, const char *s2, rsize_t s2max,
clib_c11_violation ("substring NULL");
if (s1 && s1max && (s1[clib_strnlen (s1, s1max)] != '\0'))
clib_c11_violation ("s1 unterminated");
- if (s2 && s2max && (s2[clib_strnlen (s2, s1max)] != '\0'))
+ if (s2 && s2max && (s2[clib_strnlen (s2, s2max)] != '\0'))
clib_c11_violation ("s2 unterminated");
return EINVAL;
}