diff options
| author |   Marco Varlese <marco.varlese@suse.de> | 2018-07-12 14:58:44 +0200 |
|---|---|---|
| committer |   Dave Barach <openvpp@barachs.net> | 2018-07-18 18:54:56 +0000 |
| commit | 400378f056f18e9982684feff094258288ae748d (patch) | |
| tree | 0149fbb00a2a1d25e228c7693efdf2e0ddee2316 | |
| parent | e91bdb3783653b34c1bbf9738a739e646d02f533 (diff) | |
DPDK: coverity scan warnings
This patch addresses the coverity scan warnings reported for the DPDK
plugin.
Change-Id: Ie7ac7ffcf4a6c63245eae0f9910a193ab1e318a8
Signed-off-by: Marco Varlese <marco.varlese@suse.de>
| -rw-r--r-- | src/plugins/dpdk/device/flow.c | 5 | ||||
| -rw-r--r-- | src/plugins/dpdk/device/init.c | 6 |
2 files changed, 4 insertions, 7 deletions
diff --git a/src/plugins/dpdk/device/flow.c b/src/plugins/dpdk/device/flow.c index becd39704b8..31818f1c447 100644 --- a/src/plugins/dpdk/device/flow.c +++ b/src/plugins/dpdk/device/flow.c @@ -368,11 +368,10 @@ format_dpdk_flow (u8 * s, va_list * args) return s; } - fe = vec_elt_at_index (xd->flow_entries, private_data); - - if (!fe) + if (private_data > vec_len (xd->flow_entries)) return format (s, "unknown flow"); + fe = vec_elt_at_index (xd->flow_entries, private_data); s = format (s, "mark %u", fe->mark); return s; } diff --git a/src/plugins/dpdk/device/init.c b/src/plugins/dpdk/device/init.c index bd249e91b28..f0907795255 100644 --- a/src/plugins/dpdk/device/init.c +++ b/src/plugins/dpdk/device/init.c @@ -701,7 +701,7 @@ dpdk_lib_init (dpdk_main_t * dm) } if (dm->conf->no_tx_checksum_offload == 0) - if (xd->flags & DPDK_DEVICE_FLAG_TX_OFFLOAD) + if (xd->flags & DPDK_DEVICE_FLAG_TX_OFFLOAD && hi != NULL) hi->flags |= VNET_HW_INTERFACE_FLAG_SUPPORTS_TX_L4_CKSUM_OFFLOAD; dpdk_device_setup (xd); @@ -1605,9 +1605,7 @@ dpdk_process (vlib_main_t * vm, vlib_node_runtime_t * rt, vlib_frame_t * f) xd = &dm->devices[j]; } } - ASSERT (xd != NULL); - - if (xd->pmd == VNET_DPDK_PMD_BOND) + if (xd != NULL && xd->pmd == VNET_DPDK_PMD_BOND) { u8 addr[6]; dpdk_portid_t slink[16]; |