summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYoann Desmouceaux <ydesmouc@cisco.com>2017-09-20 10:08:28 +0200
committerChris Luke <chris_luke@comcast.com>2017-09-20 14:40:49 +0000
commit561ae0a63516e092672532424904706f51eb2b84 (patch)
treef45c001fa9f2e41c8d5ae3a8f11c4c47bc3c68f6
parent6b297aa1f5cf8de294dc839edbce5470318606c8 (diff)
CLI: fix segfault when browsing an empty history
When one starts VPP, types a command, presses up rather than enter, then types a new command, unix_cli_line_process_one() segfaults. This is due to cf->cursor not being reset upon pressing up if the history is empty. Change-Id: Ie503f20a9cb551e735abb8b0f4feb8c0006d2b61 Signed-off-by: Yoann Desmouceaux <ydesmouc@cisco.com>
-rw-r--r--src/vlib/unix/cli.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/src/vlib/unix/cli.c b/src/vlib/unix/cli.c
index 1624ce387fb..0e035b1342b 100644
--- a/src/vlib/unix/cli.c
+++ b/src/vlib/unix/cli.c
@@ -1406,10 +1406,8 @@ unix_cli_line_process_one (unix_cli_main_t * cm,
unix_vlib_cli_output_cooked (cf, uf, cf->current_command,
vec_len (cf->current_command));
}
- cf->cursor = vec_len (cf->current_command);
-
- break;
}
+ cf->cursor = vec_len (cf->current_command);
break;
case UNIX_CLI_PARSE_ACTION_HOME: