summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatthew Smith <mgsmith@netgate.com>2021-02-16 10:02:46 -0600
committerNeale Ranns <neale@graphiant.com>2021-02-17 08:12:04 +0000
commit6abdf34d3a4e47fb9bb5d8052e2187af0ba256d8 (patch)
tree7fe35655268496ff2e440994abb0ed624eb0c9c0
parent93c4b1bb3f9c9e3871d51b0fd52d935555df2521 (diff)
linux-cp: fix coverity defect
Type: fix If no host interface name is passed to the CLI command which creates an interface pair, NULL gets passed to lcp_itf_pair_create() and a seg fault occurs. Check whether a host interface name was provided and fail gracefully if none was given. Change-Id: I82886f4c2ee710e206c751c34a74399112e9062c Signed-off-by: Matthew Smith <mgsmith@netgate.com>
-rw-r--r--src/plugins/linux-cp/lcp_cli.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/src/plugins/linux-cp/lcp_cli.c b/src/plugins/linux-cp/lcp_cli.c
index 3b0598c1b66..0231f67f835 100644
--- a/src/plugins/linux-cp/lcp_cli.c
+++ b/src/plugins/linux-cp/lcp_cli.c
@@ -72,6 +72,12 @@ lcp_itf_pair_create_command_fn (vlib_main_t *vm, unformat_input_t *input,
unformat_free (line_input);
+ if (!host_if_name)
+ {
+ vec_free (ns);
+ return clib_error_return (0, "host interface name required");
+ }
+
if (sw_if_index == ~0)
{
vec_free (host_if_name);