summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBenoît Ganne <bganne@cisco.com>2020-11-25 13:53:21 +0100
committerBenoît Ganne <bganne@cisco.com>2020-11-25 16:49:47 +0100
commit2113c7f28b154df16af3637f67484971759a00a7 (patch)
tree95a4ceaae3ec190033286ad2fc059065da2eca76
parent4ac36bcb190b85e6541d27072157fdcee42bee23 (diff)
dns: fix double-unlock
dns cache should no longer be unlocked by caller. Type: fix Fixes: 84a563ae4050cc0389dcd438fbe9ea882f2b8404 Change-Id: I3708718ae8f00e4e4f4e04381caa0095c8494b82 Signed-off-by: Benoît Ganne <bganne@cisco.com>
-rw-r--r--src/plugins/dns/dns.c12
1 files changed, 0 insertions, 12 deletions
diff --git a/src/plugins/dns/dns.c b/src/plugins/dns/dns.c
index de1862dd52c..f063e4f9e26 100644
--- a/src/plugins/dns/dns.c
+++ b/src/plugins/dns/dns.c
@@ -1471,12 +1471,6 @@ vl_api_dns_resolve_name_t_handler (vl_api_dns_resolve_name_t * mp)
rmp->retval = clib_host_to_net_u32 (rv);
}));
/* *INDENT-ON* */
-
- /*
- * dns_resolve_name leaves the cache locked when it returns
- * a cached result, so unlock it here.
- */
- dns_cache_unlock (dm);
}
static void
@@ -1551,12 +1545,6 @@ vl_api_dns_resolve_ip_t_handler (vl_api_dns_resolve_ip_t * mp)
rmp->retval = clib_host_to_net_u32 (rv);
}));
/* *INDENT-ON* */
-
- /*
- * vnet_dns_resolve_name leaves the cache locked when it returns
- * a cached result, so unlock it here.
- */
- dns_cache_unlock (dm);
}
static clib_error_t *