summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndrew Yourtchenko <ayourtch@gmail.com>2022-09-15 11:46:30 +0000
committerAndrew Yourtchenko <ayourtch@gmail.com>2022-09-15 11:46:30 +0000
commit6e1eaad216c41ce1cb4af13a2214f4d86e094414 (patch)
treed6fad719bedb93c2125053ff5dbe0ac28f15e064
parent5f694d1ecfbe2315e9bbcc98a83b83620e6f6b94 (diff)
prom: fix coverity 277312, 277317
If one attempts to add a pattern with zero length, first time it will succeed, and the second time it will cause an invalid memcmp call. Solution: do not allow to add zero-length patterns. Type: fix Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com> Change-Id: Ic08e021486153be605a4b12a2fe4422307bf68d2
-rw-r--r--src/plugins/prom/prom.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/plugins/prom/prom.c b/src/plugins/prom/prom.c
index 6db50204d65..3e0fa3b408d 100644
--- a/src/plugins/prom/prom.c
+++ b/src/plugins/prom/prom.c
@@ -305,6 +305,8 @@ prom_stat_patterns_add (u8 **patterns)
{
found = 0;
len = vec_len (*pattern);
+ if (len == 0)
+ continue;
vec_foreach (existing, pm->stats_patterns)
{
if (vec_len (*existing) != len)