diff options
| author |   Florin Coras <fcoras@cisco.com> | 2023-03-01 22:22:30 -0800 |
|---|---|---|
| committer |   Dave Wallace <dwallacelf@gmail.com> | 2023-03-06 23:01:19 +0000 |
| commit | a41a0b5a4c8430a6141fc847d43484ab1c4b2a0a (patch) | |
| tree | aa699eea67aac28b7dd6057a1ba783fbbce28c57 | |
| parent | c86662a213ce751354ac513a3da95117fff31845 (diff) | |
vcl: do not stop listeners on vls epoll del
Although removal from epoll means listener no longer accepts new
sessions, the accept queue built by vpp cannot be drained by stopping
the listener. Morover, some applications, e.g., nginx, might constantly
remove and add listeners to their epfds. Removing listeners in such
situations causes a lot of churn in vpp as segments and segment managers
need to be recreated.
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ia412b3f8d50fbb4881a99ff024f798353b521af7
| -rw-r--r-- | src/vcl/vcl_locked.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/src/vcl/vcl_locked.c b/src/vcl/vcl_locked.c index 8b0c66d4bdd..563d97ef804 100644 --- a/src/vcl/vcl_locked.c +++ b/src/vcl/vcl_locked.c @@ -1312,7 +1312,13 @@ vls_mp_checks (vcl_locked_session_t * vls, int is_add) vls_listener_wrk_set (vls, vls->vcl_wrk_index, 1 /* is_active */); break; } - vls_listener_wrk_stop_listen (vls, vls->vcl_wrk_index); + /* Although removal from epoll means listener no longer accepts new + * sessions, the accept queue built by vpp cannot be drained by stopping + * the listener. Morover, some applications, e.g., nginx, might + * constantly remove and add listeners to their epfds. Removing + * listeners in such situations causes a lot of churn in vpp as segments + * and segment managers need to be recreated. */ + /* vls_listener_wrk_stop_listen (vls, vls->vcl_wrk_index); */ break; case VCL_STATE_LISTEN_NO_MQ: if (!is_add) |