diff options
| author |   Steven Luong <sluong@cisco.com> | 2022-05-06 13:34:10 -0700 |
|---|---|---|
| committer |   Neale Ranns <neale@graphiant.com> | 2022-05-09 00:35:48 +0000 |
| commit | fdc17b1ae7743bc37d4e08467d0295d6f277ec12 (patch) | |
| tree | 9ced4be6daf0ea7c3383bc7b2c45f6be75f35378 | |
| parent | 01f6c7353084d1180387ae64b936e96028e17fbd (diff) | |
vhost: memory leak upon deleting vhost-user interface
We allocate vring_spinlock for all vrings in the vui, not just the ones
being used. So when we free the vui, we have to free vring_spinlock for
all vrings, not just the one being used.
Type: fix
Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I3951fda71ce6e11474b04302116ea9e08b404758
| -rw-r--r-- | src/vnet/devices/virtio/vhost_user.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/src/vnet/devices/virtio/vhost_user.c b/src/vnet/devices/virtio/vhost_user.c index 9c585722b48..b6e0806db90 100644 --- a/src/vnet/devices/virtio/vhost_user.c +++ b/src/vnet/devices/virtio/vhost_user.c @@ -1414,10 +1414,8 @@ vhost_user_term_if (vhost_user_intf_t * vui) vhost_user_update_gso_interface_count (vui, 0 /* delete */ ); vhost_user_update_iface_state (vui); - FOR_ALL_VHOST_RX_TXQ (q, vui) - { + for (q = 0; q < vec_len (vui->vrings); q++) clib_spinlock_free (&vui->vrings[q].vring_lock); - } if (vui->unix_server_index != ~0) { |