diff options
| author |   Yulong Pei <yulong.pei@intel.com> | 2019-08-23 17:24:13 +0800 |
|---|---|---|
| committer |   Damjan Marion <dmarion@me.com> | 2019-08-29 12:34:16 +0000 |
| commit | 71f36067ca923fa4eb10060d6f6878f5fa864673 (patch) | |
| tree | 4058c86e0aab11831953aa8b8bf6b3482df567e3 | |
| parent | 73cad33b56ffc08943e9c0d73ecb14466558baae (diff) | |
lb: fix memcpy error issue
vl_api_prefix_t size is 21 byte, ip46_address_t size is 16 byte, only copy
16 byte of vl_api_prefix_t to ip46_address_t is not correct.
Type:fix
Change-Id: I35ede7836a0c878d39388b29b15d91bb08f87a07
Signed-off-by: Yulong Pei <yulong.pei@intel.com>
| -rw-r--r-- | src/plugins/lb/api.c | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/src/plugins/lb/api.c b/src/plugins/lb/api.c index 86e2ce08ed7..53541799f49 100644 --- a/src/plugins/lb/api.c +++ b/src/plugins/lb/api.c @@ -120,7 +120,7 @@ vl_api_lb_add_del_vip_t_handler mp->protocol = ~0; } - memcpy (&(args.prefix), &mp->pfx, sizeof(args.prefix)); + ip_address_decode (&mp->pfx.address, &(args.prefix)); if (mp->is_del) { u32 vip_index; @@ -210,14 +210,10 @@ vl_api_lb_add_del_as_t_handler int rv = 0; u32 vip_index; ip46_address_t vip_ip_prefix; - - memcpy(&vip_ip_prefix, &mp->pfx, - sizeof(vip_ip_prefix)); - ip46_address_t as_address; - memcpy(&as_address, &mp->as_address, - sizeof(as_address)); + ip_address_decode (&mp->pfx.address, &vip_ip_prefix); + ip_address_decode (&mp->as_address, &as_address); if ((rv = lb_vip_find_index(&vip_ip_prefix, mp->pfx.len, mp->protocol, ntohs(mp->port), &vip_index))) |