diff options
| author |   Steven Luong <sluong@cisco.com> | 2019-02-21 11:58:14 -0800 |
|---|---|---|
| committer | Steven Luong <sluong@cisco.com> | 2019-02-21 12:01:10 -0800 |
| commit | 3be3cd60bc41d095174ea413aa753a7bd9eff73e (patch) | |
| tree | a89ab62f78c743934b143ec0fec4d99a688123a0 | |
| parent | 5d0d5494db58422eb528c0f8b39a86ea966505e9 (diff) | |
string_test: Coverity woe
Coverity complains about dead code as shown below and it is right.
The fix is to simply remove the dead code.
503 if (v_indicator != indicator)
CID 190173 (#3 of 3): Logically dead code (DEADCODE)
dead_error_line: Execution cannot reach this statement: return -1;.
504 return -1;
Change-Id: Ibca9e10451a4459db099bef5ecc6939474bdb903
Signed-off-by: Steven Luong <sluong@cisco.com>
| -rw-r--r-- | src/plugins/unittest/string_test.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/plugins/unittest/string_test.c b/src/plugins/unittest/string_test.c index cbceb8fb3b2..7e08bdfa29c 100644 --- a/src/plugins/unittest/string_test.c +++ b/src/plugins/unittest/string_test.c @@ -500,8 +500,6 @@ test_clib_strncmp (vlib_main_t * vm, unformat_input_t * input) v_indicator = strncmp (s1, "Every moment is a fresh beginning", s1len + 1); if (v_indicator != 0) return -1; - if (v_indicator != indicator) - return -1; /* unterminated s1 */ s1[s1len] = 0x1; |