diff options
| author |   John Lo <loj@cisco.com> | 2020-05-12 22:34:39 -0400 |
|---|---|---|
| committer | John Lo <loj@cisco.com> | 2020-06-01 21:16:37 +0000 |
| commit | 5e69119cdda353988cbd138665193231daf271c9 (patch) | |
| tree | 6294d75c2380fd09cd849502c85285dc09a3d6ec /extras | |
| parent | ab572152d9cbed7944442d07a6bd21c43ad1c83d (diff) | |
ethernet: fix DMAC check and skip unnecessary ones (VPP-1868)
Fix and optimize DMAC check in ethernet-input node to utilize NIC or
driver which support L3 DMAC-filtering mode so that DMAC check can be
bypassed safely for interfaces/sub-interfaces in L3 mode.
Checking of interface in L3-DMAC-filtering state to avoid DMAC check
require the following:
a) Fix interface driver init sequence for devices which supports L3
DMAC-filtering to indicate its capability and initialize interface
to L3 DMAC-filtering state.
b) Fix ethernet_set_flags() function and its associated callback
flags_change() functions registered by various drivers in interface
infra to provide proper L3 DMAC filtering status.
Maintain interface/sub-interface L3 config count so DMAC checks can be
bypassed if L3 forwarding is not setup on any main/sub-interfaces.
Type: fix
Ticket: VPP-1868
Signed-off-by: John Lo <loj@cisco.com>
Change-Id: I204d90459c13e9e486cfcba4e64e3d479bc9f2ae
(cherry picked from commit 4a302ee7c75f3d4fd1a73a9d1f6c34b3bde8d620)
Diffstat (limited to 'extras')
| -rw-r--r-- | extras/deprecated/ixge/ixge.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/extras/deprecated/ixge/ixge.c b/extras/deprecated/ixge/ixge.c index 6ab79c9872c..471fbedb92f 100644 --- a/extras/deprecated/ixge/ixge.c +++ b/extras/deprecated/ixge/ixge.c @@ -2605,10 +2605,12 @@ ixge_flag_change (vnet_main_t * vnm, vnet_hw_interface_t * hw, u32 flags) old = r->filter_control; - if (flags & ETHERNET_INTERFACE_FLAG_ACCEPT_ALL) + if (flags == ETHERNET_INTERFACE_FLAG_ACCEPT_ALL) r->filter_control = old | (1 << 9) /* unicast promiscuous */ ; - else + else if (flags == ETHERNET_INTERFACE_FLAGS_DEFAULT_L3) r->filter_control = old & ~(1 << 9); + else + return ~0; return old; } |