Coverity fixes, VPP-486 - vpp - Vector Packet Processing

diff options

author	Dave Barach <dave@barachs.net>	2016-12-16 09:20:04 -0500
committer	Neale Ranns <nranns@cisco.com>	2016-12-16 20:31:18 +0000
commit	bd6462e16a55a63561bfaaf75018aa378f201343 (patch)
tree	b7acae918e636950957c9229003a556a6f610c15 /plugins/acl-plugin
parent	d6900496dd3ecc807fb2936d3b1bb8f58a2ddf29 (diff)

Coverity fixes, VPP-486

Change-Id: I8906bb983128e8f6e2664e367d2015325c1125fb Signed-off-by: Dave Barach <dave@barachs.net>

Diffstat (limited to 'plugins/acl-plugin')

-rw-r--r--

plugins/acl-plugin/acl/l2sess_node.c

1 files changed, 2 insertions, 2 deletions

/* * Copyright (c) 2015 Cisco and/or its affiliates. * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at: * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ /* * vnet/buffer.h: vnet buffer flags * * Copyright (c) 2008 Eliot Dresselhaus * * Permission is hereby granted, free of charge, to any person obtaining * a copy of this software and associated documentation files (the * "Software"), to deal in the Software without restriction, including * without limitation the rights to use, copy, modify, merge, publish, * distribute, sublicense, and/or sell copies of the Software, and to * permit persons to whom the Software is furnished to do so, subject to * the following conditions: * * The above copyright notice and this permission notice shall be * included in all copies or substantial portions of the Software. * * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE * LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION * OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION * WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */ #ifndef included_vnet_buffer_h #define included_vnet_buffer_h #include <vlib/vlib.h> /** * Flags that are set in the high order bits of ((vlib_buffer*)b)->flags */ #define foreach_vnet_buffer_flag \ _( 1, L4_CHECKSUM_COMPUTED, "l4-cksum-computed") \ _( 2, L4_CHECKSUM_CORRECT, "l4-cksum-correct") \ _( 3, VLAN_2_DEEP, "vlan-2-deep") \ _( 4, VLAN_1_DEEP, "vlan-1-deep") \ _( 5, SPAN_CLONE, "span-clone") \ _( 6, HANDOFF_NEXT_VALID, "handoff-next-valid") \ _( 7, LOCALLY_ORIGINATED, "local") \ _( 8, IS_IP4, "ip4") \ _( 9, IS_IP6, "ip6") \ _(10, OFFLOAD_IP_CKSUM, "offload-ip-cksum") \ _(11, OFFLOAD_TCP_CKSUM, "offload-tcp-cksum") \ _(12, OFFLOAD_UDP_CKSUM, "offload-udp-cksum") \ _(13, IS_NATED, "nated") \ _(14, L2_HDR_OFFSET_VALID, 0) \ _(15, L3_HDR_OFFSET_VALID, 0) \ _(16, L4_HDR_OFFSET_VALID, 0) \ _(17, FLOW_REPORT, "flow-report") \ _(18, IS_DVR, "dvr") \ _(19, QOS_DATA_VALID, 0) #define VNET_BUFFER_FLAGS_VLAN_BITS \ (VNET_BUFFER_F_VLAN_1_DEEP | VNET_BUFFER_F_VLAN_2_DEEP) enum { #define _(bit, name, v) VNET_BUFFER_F_##name = (1 << LOG2_VLIB_BUFFER_FLAG_USER(bit)), foreach_vnet_buffer_flag #undef _ }; enum { #define _(bit, name, v) VNET_BUFFER_F_LOG2_##name = LOG2_VLIB_BUFFER_FLAG_USER(bit), foreach_vnet_buffer_flag #undef _ }; #define foreach_buffer_opaque_union_subtype \ _(ip) \ _(swt) \ _(l2) \ _(l2t) \ _(l2_classify) \ _(handoff) \ _(policer) \ _(ipsec) \ _(map) \ _(map_t) \ _(ip_frag) \ _(mpls) \ _(tcp) /* * vnet stack buffer opaque array overlay structure. * The vnet_buffer_opaque_t *must* be the same size as the * vlib_buffer_t "opaque" structure member, 32 bytes. * * When adding a union type, please add a stanza to * foreach_buffer_opaque_union_subtype (directly above). * Code in vnet_interface_init(...) verifies the size * of the union, and will announce any deviations in an * impossible-to-miss manner. */ typedef struct { u32 sw_if_index[VLIB_N_RX_TX]; i16 l2_hdr_offset; i16 l3_hdr_offset; i16 l4_hdr_offset; u8 feature_arc_index; u8 dont_waste_me; union { /* IP4/6 buffer opaque. */ struct { /* Adjacency from destination IP address lookup [VLIB_TX]. Adjacency from source IP address lookup [VLIB_RX]. This gets set to ~0 until source lookup is performed. */ u32 adj_index[VLIB_N_RX_TX]; union { struct { /* Flow hash value for this packet computed from IP src/dst address protocol and ports. */ u32 flow_hash; union { /* next protocol */ u32 save_protocol; /* Hint for transport protocols */ u32 fib_index; }; /* Rewrite length */ u32 save_rewrite_length; /* MFIB RPF ID */ u32 rpf_id; }; /* ICMP */ struct { u8 type; u8 code; u32 data; } icmp; /* reassembly */ union { u32 pad[2]; /* do not overlay w/ ip.adj_index[0,1] */ /* in/out variables */ struct { u32 next_index; /* index of next node - ignored if "feature" node */ u16 estimated_mtu; /* estimated MTU calculated during reassembly */ }; /* internal variables used during reassembly */ struct { u16 fragment_first; u16 fragment_last; u16 range_first; u16 range_last; u32 next_range_bi; u16 ip6_frag_hdr_offset; }; } reass; }; } ip; /* * MPLS: * data copied from the MPLS header that was popped from the packet * during the look-up. */ struct { /* do not overlay w/ ip.adj_index[0,1] nor flow hash */ u32 pad[VLIB_N_RX_TX + 1]; u8 ttl; u8 exp; u8 first; /* Rewrite length */ u32 save_rewrite_length; /* * BIER - the nubmer of bytes in the header. * the len field inthe header is not authoritative. It's the * value in the table that counts. */ struct { u8 n_bytes; } bier; } mpls; /* ip4-in-ip6 softwire termination, only valid there */ struct { u8 swt_disable; u32 mapping_index; } swt; /* l2 bridging path, only valid there */ struct opaque_l2 { u32 feature_bitmap; u16 bd_index; /* bridge-domain index */ u8 l2_len; /* ethernet header length */ u8 shg; /* split-horizon group */ u16 l2fib_sn; /* l2fib bd/int seq_num */ u8 bd_age; /* aging enabled */ } l2; /* l2tpv3 softwire encap, only valid there */ struct { u32 pad[4]; /* do not overlay w/ ip.adj_index[0,1] */ u8 next_index; u32 session_index; } l2t; /* L2 classify */ struct { struct opaque_l2 pad; union { u32 table_index; u32 opaque_index; }; u64 hash; } l2_classify; /* IO - worker thread handoff */ struct { u32 next_index; } handoff; /* vnet policer */ struct { u32 pad[8 - VLIB_N_RX_TX - 1]; /* to end of opaque */ u32 index; } policer; /* interface output features */ struct { u32 flags; u32 sad_index; } ipsec; /* MAP */ struct { u16 mtu; } map; /* MAP-T */ struct { u32 map_domain_index; struct { u32 saddr, daddr; u16 frag_offset; //Fragmentation header offset u16 l4_offset; //L4 header overall offset u8 l4_protocol; //The final protocol number } v6; //Used by ip6_map_t only u16 checksum_offset; //L4 checksum overall offset u16 mtu; //Exit MTU } map_t; /* IP Fragmentation */ struct { u32 pad[2]; /* do not overlay w/ ip.adj_index[0,1] */ u16 header_offset; u16 mtu; u8 next_index; u8 flags; //See ip_frag.h } ip_frag; /* COP - configurable junk filter(s) */ struct { /* Current configuration index. */ u32 current_config_index; } cop; /* LISP */ struct { /* overlay address family */ u16 overlay_afi; } lisp; /* Driver rx feature */ struct { u32 saved_next_index; /**< saved by drivers for short-cut */ u16 buffer_advance; } device_input_feat; /* TCP */ struct { u32 connection_index; u32 seq_number; u32 seq_end; u32 ack_number; u16 hdr_offset; /**< offset relative to ip hdr */ u16 data_offset; /**< offset relative to ip hdr */ u16 data_len; /**< data len */ u8 flags; } tcp; /* SCTP */ struct { u32 connection_index; u16 sid; /**< Stream ID */ u16 ssn; /**< Stream Sequence Number */ u32 tsn; /**< Transmission Sequence Number */ u16 hdr_offset; /**< offset relative to ip hdr */ u16 data_offset; /**< offset relative to ip hdr */ u16 data_len; /**< data len */ u8 subconn_idx; /**< index of the sub_connection being used */ u8 flags; } sctp; /* SNAT */ struct { u32 flags; } snat; u32 unused[6]; }; } vnet_buffer_opaque_t; /* * The opaque field of the vlib_buffer_t is intepreted as a * vnet_buffer_opaque_t. Hence it should be big enough to accommodate one. */ STATIC_ASSERT (sizeof (vnet_buffer_opaque_t) <= STRUCT_SIZE_OF (vlib_buffer_t, opaque), "VNET buffer meta-data too large for vlib_buffer"); #define vnet_buffer(b) ((vnet_buffer_opaque_t *) (b)->opaque) /* Full cache line (64 bytes) of additional space */ typedef struct { /** * QoS marking data that needs to persist from the recording nodes * (nominally in the ingress path) to the marking node (in the * egress path) */ struct { u8 bits; u8 source; } qos; u8 __unused[2]; /* Group Based Policy */ struct { u32 src_epg; } gbp; union { struct { #if VLIB_BUFFER_TRACE_TRAJECTORY > 0 /* buffer trajectory tracing */ u16 *trajectory_trace; #endif }; struct { u64 pad[1]; u64 pg_replay_timestamp; }; u32 unused[10]; }; } vnet_buffer_opaque2_t; #define vnet_buffer2(b) ((vnet_buffer_opaque2_t *) (b)->opaque2) /* * The opaque2 field of the vlib_buffer_t is intepreted as a * vnet_buffer_opaque2_t. Hence it should be big enough to accommodate one. */ STATIC_ASSERT (sizeof (vnet_buffer_opaque2_t) <= STRUCT_SIZE_OF (vlib_buffer_t, opaque2), "VNET buffer opaque2 meta-data too large for vlib_buffer"); format_function_t format_vnet_buffer; #endif /* included_vnet_buffer_h */ /* * fd.io coding-style-patch-verification: ON * * Local Variables: * eval: (c-set-style "gnu") * End: */


context:
space:
mode: