diff options
| author |   Benoît Ganne <bganne@cisco.com> | 2019-04-30 11:50:46 +0200 |
|---|---|---|
| committer |   Damjan Marion <dmarion@me.com> | 2019-06-07 11:21:59 +0000 |
| commit | 49ee68443d41ffe1ab72c964104da980a2eb4367 (patch) | |
| tree | f87d2096fbd19c629390548c7b1d6351e3479851 /src/cmake | |
| parent | 4168c4d914c36f76c45cd8c6dde207b9f1c688e2 (diff) | |
build: add -Wall and -fno-common, fix reported issues
Type: refactor
Change-Id: I8489ccd54411c2aa9355439c5641dc31012c64a2
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Signed-off-by: Damjan Marion <damarion@cisco.com>
Diffstat (limited to 'src/cmake')
| -rw-r--r-- | src/cmake/cpu.cmake | 2 | ||||
| -rw-r--r-- | src/cmake/library.cmake | 1 | ||||
| -rw-r--r-- | src/cmake/plugin.cmake | 1 |
3 files changed, 1 insertions, 3 deletions
diff --git a/src/cmake/cpu.cmake b/src/cmake/cpu.cmake index df52053bab5..e586ecc523c 100644 --- a/src/cmake/cpu.cmake +++ b/src/cmake/cpu.cmake @@ -95,7 +95,7 @@ macro(vpp_library_set_multiarch_sources lib) set(l ${lib}_${VARIANT}) add_library(${l} OBJECT ${ARGN}) set_target_properties(${l} PROPERTIES POSITION_INDEPENDENT_CODE ON) - target_compile_options(${l} PUBLIC "-DCLIB_MARCH_VARIANT=${VARIANT}" -Wall -fno-common) + target_compile_options(${l} PUBLIC "-DCLIB_MARCH_VARIANT=${VARIANT}") separate_arguments(VARIANT_FLAGS) target_compile_options(${l} PUBLIC ${VARIANT_FLAGS}) target_sources(${lib} PRIVATE $<TARGET_OBJECTS:${l}>) diff --git a/src/cmake/library.cmake b/src/cmake/library.cmake index 747aeb4705f..18ab8ed55f3 100644 --- a/src/cmake/library.cmake +++ b/src/cmake/library.cmake @@ -20,7 +20,6 @@ macro(add_vpp_library lib) ) add_library(${lib} SHARED ${ARG_SOURCES}) - target_compile_options(${lib} PRIVATE -Wall -fno-common) if(VPP_LIB_VERSION) set_target_properties(${lib} PROPERTIES SOVERSION ${VPP_LIB_VERSION}) endif() diff --git a/src/cmake/plugin.cmake b/src/cmake/plugin.cmake index 1565170dedf..b18f337f218 100644 --- a/src/cmake/plugin.cmake +++ b/src/cmake/plugin.cmake @@ -45,7 +45,6 @@ macro(add_vpp_plugin name) endforeach() add_library(${plugin_name} SHARED ${PLUGIN_SOURCES} ${api_includes}) set_target_properties(${plugin_name} PROPERTIES NO_SONAME 1) - target_compile_options(${plugin_name} PRIVATE -Wall) if(NOT VPP_EXTERNAL_PROJECT) add_dependencies(${plugin_name} vpp_version_h api_headers) endif() |