summaryrefslogtreecommitdiffstats
path: root/src/examples
diff options
context:
space:
mode:
authorDave Wallace <dwallacelf@gmail.com>2017-10-24 01:32:41 -0400
committerDave Wallace <dwallacelf@gmail.com>2017-10-24 01:32:41 -0400
commit71612d61930e57e7c8ebf9e5647b15a4b23720b2 (patch)
tree3c135af6d40442f5ae9f8397c62080e2b7e3f342 /src/examples
parent92b0275a364022af6ab828dfac83e38c0117cfe6 (diff)
Add extern to *_main global variable declarations in header files.
- Global variables declared in header files without the use of the 'extern' keword will result in multiple instances of the variable to be created by the compiler -- one for each different source file in which the the header file is included. This results in wasted memory allocated in the BSS segments as well as potentially introducing bugs in the application. Change-Id: I6ef1790b60a0bd9dd3994f8510723decf258b0cc Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Diffstat (limited to 'src/examples')
-rw-r--r--src/examples/sample-plugin/sample/sample.h2
-rw-r--r--src/examples/srv6-sample-localsid/srv6_localsid_sample.h2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/examples/sample-plugin/sample/sample.h b/src/examples/sample-plugin/sample/sample.h
index c9778f74298..a5dd5bf9803 100644
--- a/src/examples/sample-plugin/sample/sample.h
+++ b/src/examples/sample-plugin/sample/sample.h
@@ -31,7 +31,7 @@ typedef struct {
vnet_main_t * vnet_main;
} sample_main_t;
-sample_main_t sample_main;
+extern sample_main_t sample_main;
extern vlib_node_registration_t sample_node;
diff --git a/src/examples/srv6-sample-localsid/srv6_localsid_sample.h b/src/examples/srv6-sample-localsid/srv6_localsid_sample.h
index ef74ea3e5a6..16494497ccc 100644
--- a/src/examples/srv6-sample-localsid/srv6_localsid_sample.h
+++ b/src/examples/srv6-sample-localsid/srv6_localsid_sample.h
@@ -48,7 +48,7 @@ typedef struct {
u32 fib_table; /* Stupid index used as an example.. */
} srv6_localsid_sample_per_sid_memory_t ;
-srv6_localsid_sample_main_t srv6_localsid_sample_main;
+extern srv6_localsid_sample_main_t srv6_localsid_sample_main;
format_function_t format_srv6_localsid_sample;
unformat_function_t unformat_srv6_localsid_sample;