diff options
| author |   Benoît Ganne <bganne@cisco.com> | 2021-04-29 18:24:24 +0200 |
|---|---|---|
| committer |   Damjan Marion <dmarion@me.com> | 2021-05-21 19:50:14 +0000 |
| commit | a42c41be4eed3e1ce2a42038b07ce1d3420891cd (patch) | |
| tree | fc95c7c24cbef993cc2bef8742b3360123d70b66 /src/plugins/af_xdp/api.c | |
| parent | 92a8d761c412590f5112239be4c511091b2b2d5a (diff) | |
af_xdp: workaround kernel race between poll() and sendmsg()
Prior to Linux 5.6 there is a race condition between poll() and
sendmsg() in the kernel. This patch protects the syscalls with a lock
to prevent it, unless the NO_SYSCALL_LOCK flag is set at create time.
See
https://lore.kernel.org/bpf/BYAPR11MB365382C5DB1E5FCC53242609C1549@BYAPR11MB3653.namprd11.prod.outlook.com/
Type: fix
Change-Id: Ie7d4f5cb41f697b11a09b6046e54d190430d76df
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Diffstat (limited to 'src/plugins/af_xdp/api.c')
| -rw-r--r-- | src/plugins/af_xdp/api.c | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/src/plugins/af_xdp/api.c b/src/plugins/af_xdp/api.c index 7592aa4ffda..1864c4c2ee9 100644 --- a/src/plugins/af_xdp/api.c +++ b/src/plugins/af_xdp/api.c @@ -44,6 +44,17 @@ af_xdp_api_mode (vl_api_af_xdp_mode_t mode) return AF_XDP_MODE_AUTO; } +static af_xdp_create_flag_t +af_xdp_api_flags (vl_api_af_xdp_flag_t flags) +{ + af_xdp_create_flag_t cflags = 0; + + if (flags & AF_XDP_API_FLAGS_NO_SYSCALL_LOCK) + cflags |= AF_XDP_CREATE_FLAGS_NO_SYSCALL_LOCK; + + return cflags; +} + static void vl_api_af_xdp_create_t_handler (vl_api_af_xdp_create_t * mp) { @@ -59,6 +70,7 @@ vl_api_af_xdp_create_t_handler (vl_api_af_xdp_create_t * mp) args.name = mp->name[0] ? (char *) mp->name : 0; args.prog = mp->prog[0] ? (char *) mp->prog : 0; args.mode = af_xdp_api_mode (mp->mode); + args.flags = af_xdp_api_flags (mp->flags); args.rxq_size = ntohs (mp->rxq_size); args.txq_size = ntohs (mp->txq_size); args.rxq_num = ntohs (mp->rxq_num); |