diff options
author | Nathan Skrzypczak <nathan.skrzypczak@gmail.com> | 2021-02-26 18:12:20 +0100 |
---|---|---|
committer | Dave Barach <openvpp@barachs.net> | 2021-03-04 12:35:15 +0000 |
commit | 8786a4cd4a62f2817da7060afd8523857f504912 (patch) | |
tree | e191304d55a70370bae6a869cbfb7de0c7f7a0cd /src/plugins/cnat/cnat_node_vip.c | |
parent | 30ad571cc35e4dc6d4d7e50b81b97f83f8770eea (diff) |
cnat: Fix snat with dhcp
Type: fix
We didn't check that the srcEndpoint was resolved
when creating the session, we could end up sNATing
with 0.0.0.0 as src_addr
Change-Id: If8dfa577e659cfe90b148657a44c0390a7d383e9
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Diffstat (limited to 'src/plugins/cnat/cnat_node_vip.c')
-rw-r--r-- | src/plugins/cnat/cnat_node_vip.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/plugins/cnat/cnat_node_vip.c b/src/plugins/cnat/cnat_node_vip.c index bc7d30369ab..f0a4ad7d84e 100644 --- a/src/plugins/cnat/cnat_node_vip.c +++ b/src/plugins/cnat/cnat_node_vip.c @@ -62,8 +62,8 @@ cnat_vip_node_fn (vlib_main_t *vm, vlib_node_runtime_t *node, vlib_buffer_t *b, cc = cnat_client_get (vnet_buffer (b)->ip.adj_index[VLIB_TX]); - if (iproto != IP_PROTOCOL_UDP && iproto != IP_PROTOCOL_TCP - && iproto != IP_PROTOCOL_ICMP && iproto != IP_PROTOCOL_ICMP6) + /* Wrong session key */ + if (session->key.cs_proto == 0) { /* Dont translate & follow the fib programming */ next0 = cc->cc_parent.dpoi_next_node; |