diff options
| author |   Dave Barach <dave@barachs.net> | 2020-04-08 08:14:57 -0400 |
|---|---|---|
| committer |   Florin Coras <florin.coras@gmail.com> | 2020-04-08 16:29:44 +0000 |
| commit | 954c707972bf7efcd227e26d9679544813a78115 (patch) | |
| tree | 99e3ff617ceaef9c94f5cb33176ac14d248a316b /src/plugins/dhcp/dhcp4_proxy_node.c | |
| parent | 8d0d8d2fcccd77e462f30b21f7f8810db312ee62 (diff) | |
misc: check return values from vlib_buffer_copy(...)
vlib_buffer_copy(...) returns NULL if the system is temporarily out of
buffers.
This is NOT correct. Please don't be this person:
c0 = vlib_buffer_copy (vm, p0);
ci0 = vlib_get_buffer_index (vm, c0);
Type: fix
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Ic25ef58965871ea5d2b40904df9506803f69e47e
Diffstat (limited to 'src/plugins/dhcp/dhcp4_proxy_node.c')
| -rw-r--r-- | src/plugins/dhcp/dhcp4_proxy_node.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/src/plugins/dhcp/dhcp4_proxy_node.c b/src/plugins/dhcp/dhcp4_proxy_node.c index 53c95c09f12..28c3e624aa1 100644 --- a/src/plugins/dhcp/dhcp4_proxy_node.c +++ b/src/plugins/dhcp/dhcp4_proxy_node.c @@ -364,6 +364,13 @@ dhcp_proxy_to_server_input (vlib_main_t * vm, u32 ci0; c0 = vlib_buffer_copy (vm, b0); + if (c0 == NULL) + { + vlib_node_increment_counter + (vm, dhcp_proxy_to_server_node.index, + DHCP_PROXY_ERROR_ALLOC_FAIL, 1); + continue; + } VLIB_BUFFER_TRACE_TRAJECTORY_INIT (c0); ci0 = vlib_get_buffer_index (vm, c0); server = &proxy->dhcp_servers[ii]; |