summaryrefslogtreecommitdiffstats
path: root/src/plugins/dhcp/dhcp6_proxy_node.c
diff options
context:
space:
mode:
authorDave Barach <dave@barachs.net>2020-04-08 08:14:57 -0400
committerFlorin Coras <florin.coras@gmail.com>2020-04-08 16:29:44 +0000
commit954c707972bf7efcd227e26d9679544813a78115 (patch)
tree99e3ff617ceaef9c94f5cb33176ac14d248a316b /src/plugins/dhcp/dhcp6_proxy_node.c
parent8d0d8d2fcccd77e462f30b21f7f8810db312ee62 (diff)
misc: check return values from vlib_buffer_copy(...)
vlib_buffer_copy(...) returns NULL if the system is temporarily out of buffers. This is NOT correct. Please don't be this person: c0 = vlib_buffer_copy (vm, p0); ci0 = vlib_get_buffer_index (vm, c0); Type: fix Signed-off-by: Dave Barach <dave@barachs.net> Change-Id: Ic25ef58965871ea5d2b40904df9506803f69e47e
Diffstat (limited to 'src/plugins/dhcp/dhcp6_proxy_node.c')
-rw-r--r--src/plugins/dhcp/dhcp6_proxy_node.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/src/plugins/dhcp/dhcp6_proxy_node.c b/src/plugins/dhcp/dhcp6_proxy_node.c
index 272c379b6a3..95e5c9272f5 100644
--- a/src/plugins/dhcp/dhcp6_proxy_node.c
+++ b/src/plugins/dhcp/dhcp6_proxy_node.c
@@ -437,6 +437,13 @@ dhcpv6_proxy_to_server_input (vlib_main_t * vm,
u32 ci0;
c0 = vlib_buffer_copy (vm, b0);
+ if (c0 == NULL)
+ {
+ vlib_node_increment_counter
+ (vm, dhcpv6_proxy_to_server_node.index,
+ DHCPV6_PROXY_ERROR_ALLOC_FAIL, 1);
+ continue;
+ }
VLIB_BUFFER_TRACE_TRAJECTORY_INIT (c0);
ci0 = vlib_get_buffer_index (vm, c0);
server = &proxy->dhcp_servers[ii];