diff options
| author |   Damjan Marion <damarion@cisco.com> | 2022-01-06 21:14:08 +0100 |
|---|---|---|
| committer | Damjan Marion <damarion@cisco.com> | 2022-01-17 12:41:24 +0100 |
| commit | 88a9c0e02ab919cadd4e035133995a6afb4d1c32 (patch) | |
| tree | 15741e8bbe6c9d7077fa2a62b6ac369a17836cfb /src/plugins/dpdk/device | |
| parent | 81bb6fc611d321a92ad2218e1b852db67980768a (diff) | |
interface: improve MTU handling
- per hw-interface-class handlers
- ethernet set_mtu callback
- driver can now refuse MTU change
Type: improvement
Change-Id: I3d37c9129930ebec7bb70caf4263025413873048
Signed-off-by: Damjan Marion <damarion@cisco.com>
Diffstat (limited to 'src/plugins/dpdk/device')
| -rw-r--r-- | src/plugins/dpdk/device/init.c | 46 |
1 files changed, 37 insertions, 9 deletions
diff --git a/src/plugins/dpdk/device/init.c b/src/plugins/dpdk/device/init.c index 5e06e48d37e..4faf6290dba 100644 --- a/src/plugins/dpdk/device/init.c +++ b/src/plugins/dpdk/device/init.c @@ -21,6 +21,7 @@ #include <vlib/unix/unix.h> #include <vlib/log.h> +#include <vnet/vnet.h> #include <vnet/ethernet/ethernet.h> #include <vnet/interface/rx_queue_funcs.h> #include <dpdk/buffer.h> @@ -68,6 +69,41 @@ const struct { ETH_LINK_SPEED_1G, "GigabitEthernet" }, }; +static clib_error_t * +dpdk_set_mtu (vnet_main_t *vnm, vnet_hw_interface_t *hi, u32 mtu) +{ + dpdk_main_t *dm = &dpdk_main; + dpdk_device_t *xd = vec_elt_at_index (dm->devices, hi->dev_instance); + int rv; + + rv = rte_eth_dev_set_mtu (xd->port_id, mtu); + + if (rv < 0) + { + dpdk_log_err ("[%u] rte_eth_dev_set_mtu failed (mtu %u, rv %d)", + xd->port_id, mtu, rv); + switch (rv) + { + case -ENOTSUP: + return vnet_error (VNET_ERR_UNSUPPORTED, + "dpdk driver doesn't support MTU change"); + case -EBUSY: + return vnet_error (VNET_ERR_BUSY, "port is running"); + case -EINVAL: + return vnet_error (VNET_ERR_INVALID_VALUE, "invalid MTU"); + default: + return vnet_error (VNET_ERR_BUG, + "unexpected return value %d returned from " + "rte_eth_dev_set_mtu(...)", + rv); + } + } + else + dpdk_log_debug ("[%u] mtu set to %u", xd->port_id, mtu); + + return 0; +} + static u32 dpdk_flag_change (vnet_main_t * vnm, vnet_hw_interface_t * hi, u32 flags) { @@ -84,15 +120,6 @@ dpdk_flag_change (vnet_main_t * vnm, vnet_hw_interface_t * hi, u32 flags) case ETHERNET_INTERFACE_FLAG_ACCEPT_ALL: dpdk_device_flag_set (xd, DPDK_DEVICE_FLAG_PROMISC, 1); break; - case ETHERNET_INTERFACE_FLAG_MTU: - if (xd->flags & DPDK_DEVICE_FLAG_ADMIN_UP) - rte_eth_dev_stop (xd->port_id); - rte_eth_dev_set_mtu (xd->port_id, hi->max_packet_bytes); - if (xd->flags & DPDK_DEVICE_FLAG_ADMIN_UP) - rte_eth_dev_start (xd->port_id); - dpdk_log_debug ("[%u] mtu changed to %u", xd->port_id, - hi->max_packet_bytes); - return 0; default: return ~0; } @@ -370,6 +397,7 @@ dpdk_lib_init (dpdk_main_t * dm) eir.dev_instance = xd->device_index; eir.address = addr; eir.cb.flag_change = dpdk_flag_change; + eir.cb.set_mtu = dpdk_set_mtu; xd->hw_if_index = vnet_eth_register_interface (vnm, &eir); hi = vnet_get_hw_interface (vnm, xd->hw_if_index); hi->numa_node = xd->cpu_socket = (i8) rte_eth_dev_socket_id (port_id); |