diff options
author | Dave Wallace <dwallacelf@gmail.com> | 2017-10-24 01:32:41 -0400 |
---|---|---|
committer | Dave Wallace <dwallacelf@gmail.com> | 2017-10-24 01:32:41 -0400 |
commit | 71612d61930e57e7c8ebf9e5647b15a4b23720b2 (patch) | |
tree | 3c135af6d40442f5ae9f8397c62080e2b7e3f342 /src/plugins/dpdk | |
parent | 92b0275a364022af6ab828dfac83e38c0117cfe6 (diff) |
Add extern to *_main global variable declarations in header files.
- Global variables declared in header files without
the use of the 'extern' keword will result in multiple
instances of the variable to be created by the compiler
-- one for each different source file in which the
the header file is included. This results in wasted
memory allocated in the BSS segments as well as
potentially introducing bugs in the application.
Change-Id: I6ef1790b60a0bd9dd3994f8510723decf258b0cc
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Diffstat (limited to 'src/plugins/dpdk')
-rw-r--r-- | src/plugins/dpdk/device/dpdk.h | 2 | ||||
-rwxr-xr-x | src/plugins/dpdk/device/init.c | 1 | ||||
-rw-r--r-- | src/plugins/dpdk/ipsec/ipsec.c | 2 | ||||
-rw-r--r-- | src/plugins/dpdk/ipsec/ipsec.h | 2 |
4 files changed, 5 insertions, 2 deletions
diff --git a/src/plugins/dpdk/device/dpdk.h b/src/plugins/dpdk/device/dpdk.h index 9762c7137f5..a0c57ea21b3 100644 --- a/src/plugins/dpdk/device/dpdk.h +++ b/src/plugins/dpdk/device/dpdk.h @@ -332,7 +332,7 @@ typedef struct } dpdk_config_main_t; -dpdk_config_main_t dpdk_config_main; +extern dpdk_config_main_t dpdk_config_main; typedef struct { diff --git a/src/plugins/dpdk/device/init.c b/src/plugins/dpdk/device/init.c index e94d2fa8588..9e7bb75d6f3 100755 --- a/src/plugins/dpdk/device/init.c +++ b/src/plugins/dpdk/device/init.c @@ -37,6 +37,7 @@ #include <dpdk/device/dpdk_priv.h> dpdk_main_t dpdk_main; +dpdk_config_main_t dpdk_config_main; #define LINK_STATE_ELOGS 0 diff --git a/src/plugins/dpdk/ipsec/ipsec.c b/src/plugins/dpdk/ipsec/ipsec.c index 4bae8c1b0f4..6aa5fae8b26 100644 --- a/src/plugins/dpdk/ipsec/ipsec.c +++ b/src/plugins/dpdk/ipsec/ipsec.c @@ -21,6 +21,8 @@ #include <dpdk/device/dpdk.h> #include <dpdk/ipsec/ipsec.h> +dpdk_crypto_main_t dpdk_crypto_main; + #define EMPTY_STRUCT {0} static void diff --git a/src/plugins/dpdk/ipsec/ipsec.h b/src/plugins/dpdk/ipsec/ipsec.h index 98e5ad53acb..22890628ec6 100644 --- a/src/plugins/dpdk/ipsec/ipsec.h +++ b/src/plugins/dpdk/ipsec/ipsec.h @@ -144,7 +144,7 @@ typedef struct u8 enabled; } dpdk_crypto_main_t; -dpdk_crypto_main_t dpdk_crypto_main; +extern dpdk_crypto_main_t dpdk_crypto_main; static const u8 pad_data[] = { 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 0 }; |