diff options
| author |   AkshayaNadahalli <anadahal@cisco.com> | 2017-03-10 18:38:13 +0000 |
|---|---|---|
| committer |   Dave Barach <openvpp@barachs.net> | 2017-03-14 12:01:05 +0000 |
| commit | b20dd1ba714c0b6de78abfe05dbee5b076cdac72 (patch) | |
| tree | dbc1f4ec8d7626070764c3315e66945f54ffc470 /src/plugins/ioam/analyse | |
| parent | a38e0f0d14cfe633318c23d8940f2140cb2b2320 (diff) | |
IOAM Coverity fix
Coverity IDs - 163911, 163910, 163909, 163908, 163905, 163904, 163896, 161957, 161955
Change-Id: Ida822fa45c6936240f61282e2280541d7e6427b3
Signed-off-by: AkshayaNadahalli <anadahal@cisco.com>
Diffstat (limited to 'src/plugins/ioam/analyse')
| -rw-r--r-- | src/plugins/ioam/analyse/ioam_analyse.h | 10 | ||||
| -rw-r--r-- | src/plugins/ioam/analyse/ioam_summary_export.c | 1 |
2 files changed, 8 insertions, 3 deletions
diff --git a/src/plugins/ioam/analyse/ioam_analyse.h b/src/plugins/ioam/analyse/ioam_analyse.h index b7576012e56..3e04c1ca69c 100644 --- a/src/plugins/ioam/analyse/ioam_analyse.h +++ b/src/plugins/ioam/analyse/ioam_analyse.h @@ -127,7 +127,8 @@ always_inline f64 ip6_ioam_analyse_calc_delay (ioam_trace_hdr_t * trace, u16 trace_len, u8 oneway) { - u16 size_of_traceopt_per_node, size_of_all_traceopts; + u16 size_of_all_traceopts; + u8 size_of_traceopt_per_node; u8 num_nodes; u32 *start_elt, *end_elt, *uturn_elt;; u32 start_time, end_time; @@ -140,13 +141,15 @@ ip6_ioam_analyse_calc_delay (ioam_trace_hdr_t * trace, u16 trace_len, size_of_all_traceopts = trace_len; /*ioam_trace_type,data_list_elts_left */ num_nodes = (u8) (size_of_all_traceopts / size_of_traceopt_per_node); + if ((num_nodes == 0) || (num_nodes <= trace->data_list_elts_left)) + return 0; num_nodes -= trace->data_list_elts_left; start_elt = trace->elts; end_elt = trace->elts + - (u32) (size_of_traceopt_per_node * (num_nodes - 1) / sizeof (u32)); + (u32) ((size_of_traceopt_per_node / sizeof (u32)) * (num_nodes - 1)); if (oneway && (trace->ioam_trace_type & BIT_TTL_NODEID)) { @@ -225,6 +228,9 @@ ip6_ioam_analyse_hbh_trace_loopback (ioam_analyser_data_t * data, trace_data = &data->trace_data; size_of_traceopt_per_node = fetch_trace_data_size (trace->ioam_trace_type); + if (0 == size_of_traceopt_per_node) + goto end; + size_of_all_traceopts = trace_len; ptr = (u8 *) trace->elts; diff --git a/src/plugins/ioam/analyse/ioam_summary_export.c b/src/plugins/ioam/analyse/ioam_summary_export.c index 17fcf7a5b7e..9a2667f67f8 100644 --- a/src/plugins/ioam/analyse/ioam_summary_export.c +++ b/src/plugins/ioam/analyse/ioam_summary_export.c @@ -318,7 +318,6 @@ ioam_send_flows (flow_report_main_t * frm, flow_report_t * fr, tp = vlib_buffer_get_current (b0); ip = &tp->ip4; - udp = &tp->udp; h = &tp->ipfix.h; s = &tp->ipfix.s; |