diff options
| author |   Pim van Pelt <pim@ipng.nl> | 2021-08-12 21:35:06 +0200 |
|---|---|---|
| committer |   Matthew Smith <mgsmith@netgate.com> | 2021-09-09 13:02:34 +0000 |
| commit | b89c1ddcb3b4f9138ca3ebefb2115f896ff3e1bd (patch) | |
| tree | 2f828c4be47a5fe3a46d052875f8197f524ba5bd /src/plugins/linux-cp/lcp_adj.c | |
| parent | 7b46e4bc574e6dfa7f5a454a696476744625c55f (diff) | |
linux-cp: Complete interface creation logic
Linux Control Plane interface creation logic is currently only able to
create untagged interfaces, and dot1q VLAN sub-interfaces. This change
makes it possible to create dot1ad VLAN sub-ints, and Q-in-AD as well
as Q-in-Q sub-interfaces as well.
It makes the plugin a bit more robust by catching a few common errors,
such as creating an lcp on a sub-interface without its parent having
one, and creating an lcp on a sub-interface that is not exact-match.
This change has a bunch of smaller improvemnets as well. I documented
my work in this post:
https://ipng.ch/s/articles/2021/08/12/vpp-1.html
It shows that after the change is merged, all VPP interface types now
create and operate cleanly as LCP interfaces as well.
Type: improvement
Signed-off-by: Pim van Pelt <pim@ipng.nl>
Change-Id: I322669f7316d44c227090b83d6a574fb9c00e76a
Diffstat (limited to 'src/plugins/linux-cp/lcp_adj.c')
| -rw-r--r-- | src/plugins/linux-cp/lcp_adj.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/plugins/linux-cp/lcp_adj.c b/src/plugins/linux-cp/lcp_adj.c index bfbc2fec913..b10c70616b5 100644 --- a/src/plugins/linux-cp/lcp_adj.c +++ b/src/plugins/linux-cp/lcp_adj.c @@ -185,8 +185,8 @@ lcp_adj_show_cmd (vlib_main_t *vm, unformat_input_t *input, if (unformat (input, "verbose")) verbose = 1; - vlib_cli_output (vm, "Linux-CP Adjs:\n%U", BV (format_bihash), &lcp_adj_tbl, - verbose); + vlib_cli_output (vm, "linux-cp adjacencies:\n%U", BV (format_bihash), + &lcp_adj_tbl, verbose); return 0; } @@ -210,7 +210,7 @@ lcp_adj_init (vlib_main_t *vm) { adj_type = adj_delegate_register_new_type (&lcp_adj_vft); - BV (clib_bihash_init) (&lcp_adj_tbl, "linux-cp ADJ table", 1024, 1 << 24); + BV (clib_bihash_init) (&lcp_adj_tbl, "linux-cp adjacencies", 1024, 1 << 24); BV (clib_bihash_set_kvp_format_fn) (&lcp_adj_tbl, format_lcp_adj_kvp); return (NULL); |