diff options
| author |   Pim van Pelt <pim@ipng.nl> | 2023-10-06 11:26:33 +0200 |
|---|---|---|
| committer |   Matthew Smith <mgsmith@netgate.com> | 2024-01-10 14:49:25 +0000 |
| commit | 2c9b128e1b3732f9dd62699922480f9206a02b2d (patch) | |
| tree | c298875846843f34828269346adaa02f160e3e15 /src/plugins/linux-cp/lcp_mpls_sync.c | |
| parent | 2fa69effc844d7a27d46c0f163c0840df961eb2d (diff) | |
linux-cp: Fix looping netlink messages
Signal when consuming a batch of netlink messages, in order to inhibit
lcp_sync from generating new netlink messages. This avoids link up/down
state changess from triggering an infinite loop.
Do this in the regular case of nl_route_process_msgs()
and in the special case of re-synchronizing in lcp_nl_recv_dump_replies().
Type: fix
Change-Id: I419d3f9aa350c119b3778b644c65165cb4cc1bef
Signed-off-by: Pim van Pelt <pim@ipng.nl>
Diffstat (limited to 'src/plugins/linux-cp/lcp_mpls_sync.c')
| -rw-r--r-- | src/plugins/linux-cp/lcp_mpls_sync.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/plugins/linux-cp/lcp_mpls_sync.c b/src/plugins/linux-cp/lcp_mpls_sync.c index d4b0d13b907..c08fcb4d1d9 100644 --- a/src/plugins/linux-cp/lcp_mpls_sync.c +++ b/src/plugins/linux-cp/lcp_mpls_sync.c @@ -77,6 +77,8 @@ lcp_mpls_sync_state_cb (struct mpls_main_t *mm, uword opaque, u32 sw_if_index, format_lcp_itf_pair, lip); // If syncing is enabled, sync Linux state as well. + // This can happen regardless of lcp_get_netlink_processing_active(), + // provided it does not generate Netlink messages. if (!lcp_sync ()) return; |