diff options
| author |   Klement Sekera <ksekera@cisco.com> | 2021-03-24 17:29:23 +0100 |
|---|---|---|
| committer |   Ole Tr�an <otroan@employees.org> | 2021-03-31 13:40:05 +0000 |
| commit | 17bd30384cb3441d11cd65a00a3af76885288b78 (patch) | |
| tree | 8ef2c6231e91e7fbec6a3805e33090a91968f1e0 /src/plugins/nat/nat44-ei/nat44_ei_out2in.c | |
| parent | 68b493ff2fa04b3d283e9476e77ea2db116b1dd8 (diff) | |
nat: correct thread index usage
Use actual thread index from hash table instead of doing calculation.
Calculated index might be different and could lead to crash.
Type: fix
Change-Id: Iede9a67fbe541cb44eccd0d6ddf4e2c51eb35423
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Diffstat (limited to 'src/plugins/nat/nat44-ei/nat44_ei_out2in.c')
| -rw-r--r-- | src/plugins/nat/nat44-ei/nat44_ei_out2in.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/src/plugins/nat/nat44-ei/nat44_ei_out2in.c b/src/plugins/nat/nat44-ei/nat44_ei_out2in.c index 1d5ebd33cd5..1f04ba056b5 100644 --- a/src/plugins/nat/nat44-ei/nat44_ei_out2in.c +++ b/src/plugins/nat/nat44-ei/nat44_ei_out2in.c @@ -110,7 +110,12 @@ nat44_o2i_is_idle_session_cb (clib_bihash_kv_8_8_t * kv, void *arg) vec_elt_at_index (nm->per_thread_data, ctx->thread_index); clib_bihash_kv_8_8_t s_kv; - s = pool_elt_at_index (tnm->sessions, kv->value); + if (ctx->thread_index != nat_value_get_thread_index (kv)) + { + return 0; + } + + s = pool_elt_at_index (tnm->sessions, nat_value_get_session_index (kv)); sess_timeout_time = s->last_heard + (f64) nat_session_get_timeout ( &nm->timeouts, s->nat_proto, s->state); if (ctx->now >= sess_timeout_time) |