diff options
| author |   Benoît Ganne <bganne@cisco.com> | 2020-04-22 09:02:48 +0200 |
|---|---|---|
| committer |   Dave Barach <openvpp@barachs.net> | 2020-04-22 13:03:08 +0000 |
| commit | 08d01376de5abf2e93c562ee5e24cf62ce1be3ff (patch) | |
| tree | 5ff125fbf2d79ef432f9f56041fb76e4c00a6fcb /src/plugins/perfmon | |
| parent | 74ee18b0b33aad974705ae16739a86c48f3b966b (diff) | |
misc: asan: do not poison memory after munmap()
It is a bad idea to poison memory after munmap because the address space
can be reused (eg. for global data of dlopen()ed object) and ASan model
allows access by default.
Moreover, access to a stale address space will fault.
Type: fix
Change-Id: I356de422f255447d9d50a3a71fb0c2eaa790d731
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Diffstat (limited to 'src/plugins/perfmon')
| -rw-r--r-- | src/plugins/perfmon/perfmon_periodic.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/plugins/perfmon/perfmon_periodic.c b/src/plugins/perfmon/perfmon_periodic.c index 8498419f36f..37d669b8d13 100644 --- a/src/plugins/perfmon/perfmon_periodic.c +++ b/src/plugins/perfmon/perfmon_periodic.c @@ -248,8 +248,6 @@ disable_events (perfmon_main_t * pm) if (munmap (pm->perf_event_pages[i][my_thread_index], pm->page_size) < 0) clib_unix_warning ("munmap"); - CLIB_MEM_POISON (pm->perf_event_pages[i][my_thread_index], - pm->page_size); pm->perf_event_pages[i][my_thread_index] = 0; } |