diff options
author | Florin Coras <fcoras@cisco.com> | 2024-02-27 17:10:25 -0800 |
---|---|---|
committer | Dave Barach <vpp@barachs.net> | 2024-03-20 20:07:05 +0000 |
commit | e565902654aea1e73b740cf68daa3d116cc15f9e (patch) | |
tree | 096b72da34e79ab29ae517f171797c8798406545 /src/plugins/tlsopenssl | |
parent | 40c95f50bae22ac47412ad640d35a14d4597b466 (diff) |
tls: avoid app session preallocation
Since async rx event infra decouples notification event generation from
delivery we no longer run the risk of having tls realloc session pools
while session layer still holds a pointer to the accepted/connected tcp
session.
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I1bb429a058707aba1d4f32ea33615a2367e66969
Diffstat (limited to 'src/plugins/tlsopenssl')
-rw-r--r-- | src/plugins/tlsopenssl/tls_openssl.c | 14 |
1 files changed, 1 insertions, 13 deletions
diff --git a/src/plugins/tlsopenssl/tls_openssl.c b/src/plugins/tlsopenssl/tls_openssl.c index 75e58f6579a..a21e3bb54c1 100644 --- a/src/plugins/tlsopenssl/tls_openssl.c +++ b/src/plugins/tlsopenssl/tls_openssl.c @@ -263,8 +263,6 @@ openssl_check_async_status (tls_ctx_t * ctx, openssl_resume_handler * handler, static void openssl_handle_handshake_failure (tls_ctx_t * ctx) { - session_t *app_session; - /* Failed to renegotiate handshake */ if (ctx->flags & TLS_CONN_F_HS_DONE) { @@ -275,18 +273,8 @@ openssl_handle_handshake_failure (tls_ctx_t * ctx) if (SSL_is_server (((openssl_ctx_t *) ctx)->ssl)) { - /* - * Cleanup pre-allocated app session and close transport - */ - app_session = - session_get_if_valid (ctx->c_s_index, ctx->c_thread_index); - if (app_session) - { - session_free (app_session); - ctx->c_s_index = SESSION_INVALID_INDEX; - tls_disconnect_transport (ctx); - } ctx->flags |= TLS_CONN_F_NO_APP_SESSION; + tls_disconnect_transport (ctx); } else { |