diff options
| author |   Steven <sluong@cisco.com> | 2018-11-02 16:28:52 -0700 |
|---|---|---|
| committer |   Damjan Marion <dmarion@me.com> | 2018-11-07 01:13:01 +0000 |
| commit | 005e4d50416d15368a6687076c7c934f89470f72 (patch) | |
| tree | 0bc050d6c369e6b2298dbe44003605979bfa7cf0 /src/plugins/vmxnet3/vmxnet3.h | |
| parent | 6ccff02def39f314765f82a39f5dea9a667e47c8 (diff) | |
vmxnet3: reduce calling vmxnet3_reg_write_inline
In output.c, we buffer the descriptors and call vmxnet3_reg_write_inline
once outside the loop. This change improves the performance dramatically.
When refilling the ring, there is no need to inform the device unless
explicitly specified by the device (ctrl.update_prod == 1)
Change-Id: I7031d58bff0d249e913d14236d416c91eb6ab94a
Signed-off-by: Steven <sluong@cisco.com>
Diffstat (limited to 'src/plugins/vmxnet3/vmxnet3.h')
| -rw-r--r-- | src/plugins/vmxnet3/vmxnet3.h | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/src/plugins/vmxnet3/vmxnet3.h b/src/plugins/vmxnet3/vmxnet3.h index 87ccd407073..a3306895ec0 100644 --- a/src/plugins/vmxnet3/vmxnet3.h +++ b/src/plugins/vmxnet3/vmxnet3.h @@ -590,6 +590,7 @@ vmxnet3_rxq_refill_ring0 (vlib_main_t * vm, vmxnet3_device_t * vd, vmxnet3_rx_desc *rxd; u16 n_refill, n_alloc; vmxnet3_rx_ring *ring; + vmxnet3_queues *q; ring = &rxq->rx_ring[0]; n_refill = rxq->size - ring->fill; @@ -620,7 +621,9 @@ vmxnet3_rxq_refill_ring0 (vlib_main_t * vm, vmxnet3_device_t * vd, n_alloc--; } - vmxnet3_reg_write_inline (vd, 0, VMXNET3_REG_RXPROD, ring->produce); + q = &vd->dma->queues; + if (PREDICT_FALSE (q->rx.ctrl.update_prod)) + vmxnet3_reg_write_inline (vd, 0, VMXNET3_REG_RXPROD, ring->produce); return 0; } @@ -632,6 +635,7 @@ vmxnet3_rxq_refill_ring1 (vlib_main_t * vm, vmxnet3_device_t * vd, vmxnet3_rx_desc *rxd; u16 n_refill, n_alloc; vmxnet3_rx_ring *ring; + vmxnet3_queues *q; ring = &rxq->rx_ring[1]; n_refill = rxq->size - ring->fill; @@ -662,7 +666,9 @@ vmxnet3_rxq_refill_ring1 (vlib_main_t * vm, vmxnet3_device_t * vd, n_alloc--; } - vmxnet3_reg_write_inline (vd, 0, VMXNET3_REG_RXPROD2, ring->produce); + q = &vd->dma->queues; + if (PREDICT_FALSE (q->rx.ctrl.update_prod)) + vmxnet3_reg_write_inline (vd, 0, VMXNET3_REG_RXPROD2, ring->produce); return 0; } |