diff options
| author |   Benoît Ganne <bganne@cisco.com> | 2019-02-12 13:35:08 +0100 |
|---|---|---|
| committer |   Damjan Marion <dmarion@me.com> | 2019-02-14 17:18:36 +0000 |
| commit | 47727c02df4c79c21c6ceffaff65222c32cf6996 (patch) | |
| tree | ff56da0094b29da6d07746b08574dfb194ed9113 /src/plugins | |
| parent | 8f6c1dda355b6e4d00dc4e41e65a25e1fd1507ee (diff) | |
Add -fno-common compile option
-fno-common makes sure we do not have multiple declarations of the same
global symbol across compilation units. It helps debug nasty linkage
bugs by guaranteeing that all reference to a global symbol use the same
underlying object.
It also helps avoiding benign mistakes such as declaring enum as global
objects instead of types in headers (hence the minor fixes scattered
across the source).
Change-Id: I55c16406dc54ff8a6860238b90ca990fa6b179f1
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Diffstat (limited to 'src/plugins')
| -rw-r--r-- | src/plugins/acl/fa_node.h | 2 | ||||
| -rw-r--r-- | src/plugins/avf/avf.h | 2 | ||||
| -rw-r--r-- | src/plugins/memif/private.h | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/src/plugins/acl/fa_node.h b/src/plugins/acl/fa_node.h index 83a1984c22f..c969377ded7 100644 --- a/src/plugins/acl/fa_node.h +++ b/src/plugins/acl/fa_node.h @@ -241,7 +241,7 @@ typedef enum { } acl_fa_next_t; -enum +typedef enum { ACL_FA_CLEANER_RESCHEDULE = 1, ACL_FA_CLEANER_DELETE_BY_SW_IF_INDEX, diff --git a/src/plugins/avf/avf.h b/src/plugins/avf/avf.h index b79a22b073f..9836451e012 100644 --- a/src/plugins/avf/avf.h +++ b/src/plugins/avf/avf.h @@ -168,7 +168,7 @@ typedef struct #define AVF_RX_VECTOR_SZ VLIB_FRAME_SIZE -enum +typedef enum { AVF_PROCESS_EVENT_START = 1, AVF_PROCESS_EVENT_STOP = 2, diff --git a/src/plugins/memif/private.h b/src/plugins/memif/private.h index 2aa1f5a0cdc..4613512041d 100644 --- a/src/plugins/memif/private.h +++ b/src/plugins/memif/private.h @@ -255,7 +255,7 @@ extern memif_main_t memif_main; extern vnet_device_class_t memif_device_class; extern vlib_node_registration_t memif_input_node; -enum +typedef enum { MEMIF_PROCESS_EVENT_START = 1, MEMIF_PROCESS_EVENT_STOP = 2, |