diff options
| author |   Neale Ranns <neale.ranns@cisco.com> | 2018-03-21 16:34:28 -0700 |
|---|---|---|
| committer |   Damjan Marion <dmarion.lists@gmail.com> | 2018-03-23 03:55:54 +0000 |
| commit | 5237c77cdd8041f173ceefe4919cd7e9e1130805 (patch) | |
| tree | 8477a8d31f4b3ac09ec92edba7ff27cb7eb2aade /src/plugins | |
| parent | a005e7f0ef1564cab8db1a148091fd43d2d5af48 (diff) | |
IGMP: coverity fixes and remove checks for scapy IGMPv3
Change-Id: Ic2eddc803f9ba8215e37388a686004830211cf6f
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Diffstat (limited to 'src/plugins')
| -rw-r--r-- | src/plugins/igmp/igmp.c | 12 | ||||
| -rw-r--r-- | src/plugins/igmp/igmp.h | 2 |
2 files changed, 5 insertions, 9 deletions
diff --git a/src/plugins/igmp/igmp.c b/src/plugins/igmp/igmp.c index 97baae57f1d..e98e976cc96 100644 --- a/src/plugins/igmp/igmp.c +++ b/src/plugins/igmp/igmp.c @@ -206,7 +206,7 @@ ip4_lookup (ip4_address_t * a, igmp_membership_report_v3_t * igmp, u16 n, for (i = 0; i < n; i++) { - if ((!ip4_address_compare (a, &group_ptr (igmp, l)->dst_address)) && + if ((!ip4_address_compare (a, &(group_ptr (igmp, l)->dst_address))) && (type == group_ptr (igmp, l)->type)) { rv = 1; @@ -549,12 +549,11 @@ igmp_timer_process (vlib_main_t * vm, vlib_node_runtime_t * rt, igmp_main_t *im = &igmp_main; uword *event_data = 0, event_type; f64 time_start; - u8 enabled = 0; igmp_timer_t *timer = NULL; while (1) { - if (enabled) + if (NULL != timer) vlib_process_wait_for_event_or_clock (vm, timer->exp_time - time_start); else @@ -571,14 +570,11 @@ igmp_timer_process (vlib_main_t * vm, vlib_node_runtime_t * rt, DBG ("time: %f", vlib_time_now (vm)); /* timer expired */ - timer->func (vm, rt, im, timer); + if (NULL != timer) + timer->func (vm, rt, im, timer); next_timer: timer = igmp_get_next_timer (im); - if (timer == NULL) - enabled = 0; - else - enabled = 1; } return 0; } diff --git a/src/plugins/igmp/igmp.h b/src/plugins/igmp/igmp.h index c98cbd1dc0b..0dcf11f64f7 100644 --- a/src/plugins/igmp/igmp.h +++ b/src/plugins/igmp/igmp.h @@ -36,7 +36,7 @@ #define DBG(...) #endif /* IGMP_DBG */ -#define group_ptr(p, l) ((igmp_membership_group_v3_t *)((void*)p + l)) +#define group_ptr(p, l) ((igmp_membership_group_v3_t *)((char*)p + l)) enum { |