diff options
| author |   Dave Barach <dave@barachs.net> | 2018-10-02 16:33:56 -0400 |
|---|---|---|
| committer |   Florin Coras <florin.coras@gmail.com> | 2018-10-02 21:36:12 +0000 |
| commit | 819d5fdb39526386ee8fe4a8729f960e84443cbd (patch) | |
| tree | f81e79c45024a20e04c817d5a0f44cd26b3d6ee8 /src/plugins | |
| parent | bf49590c07162be44b21d0e0440e7fb96b2746d5 (diff) | |
VPP-1440: clean up coverity warnings
Change-Id: Ic6823fb617ecae547a5f0e28b1e037848e40f682
Signed-off-by: Dave Barach <dave@barachs.net>
Diffstat (limited to 'src/plugins')
| -rw-r--r-- | src/plugins/lb/node.c | 5 | ||||
| -rw-r--r-- | src/plugins/nsim/node.c | 8 |
2 files changed, 8 insertions, 5 deletions
diff --git a/src/plugins/lb/node.c b/src/plugins/lb/node.c index 8163e35a06e..ab192af11aa 100644 --- a/src/plugins/lb/node.c +++ b/src/plugins/lb/node.c @@ -646,13 +646,14 @@ lb_nodeport_node_fn (vlib_main_t * vm, vlib_node_runtime_t * node, entry0 = hash_get_mem(lbm->vip_index_by_nodeport, &(udp_0->dst_port)); //Enqueue to next - vnet_buffer(p0)->ip.adj_index[VLIB_TX] = entry0[0]; + vnet_buffer(p0)->ip.adj_index[VLIB_TX] = entry0 ? entry0[0] + : ADJ_INDEX_INVALID; if (PREDICT_FALSE(p0->flags & VLIB_BUFFER_IS_TRACED)) { lb_nodeport_trace_t *tr = vlib_add_trace (vm, node, p0, sizeof(*tr)); - tr->vip_index = entry0[0]; + tr->vip_index = entry0 ? entry0[0] : ADJ_INDEX_INVALID; tr->node_port = (u32) clib_net_to_host_u16 (udp_0->dst_port); } diff --git a/src/plugins/nsim/node.c b/src/plugins/nsim/node.c index e78e74482ff..dfd0bf747f1 100644 --- a/src/plugins/nsim/node.c +++ b/src/plugins/nsim/node.c @@ -125,7 +125,10 @@ nsim_inline (vlib_main_t * vm, ep->current_length); } else /* out of wheel space, drop pkt */ - b[0]->error = no_buffer_error; + { + b[0]->error = no_buffer_error; + is_drop0 = 1; + } if (is_trace) { @@ -134,8 +137,7 @@ nsim_inline (vlib_main_t * vm, nsim_trace_t *t = vlib_add_trace (vm, node, b[0], sizeof (*t)); t->expires = expires; t->is_drop = is_drop0; - if (is_drop0 == 0) - t->tx_sw_if_index = ep->tx_sw_if_index; + t->tx_sw_if_index = (is_drop0 == 0) ? ep->tx_sw_if_index : 0; } } |