summaryrefslogtreecommitdiffstats
path: root/src/plugins
diff options
context:
space:
mode:
authorDave Barach <dave@barachs.net>2019-07-23 10:22:31 -0400
committerDave Barach <dave@barachs.net>2019-10-25 18:00:05 -0400
commitb5bc2e0e1cc70eb301c864212d3a3099b08bac49 (patch)
treeced89d1e7d5f0076c3f38a6606f1e96303d7c55c /src/plugins
parente6329ada4401f4a7e418a48fe829bbc211e28b6f (diff)
vlib: address vlib_error_t scaling issue
Encoding the vpp node index into the vlib_error_t as a 10-bit quantity limits us to 1K graph nodes. Unfortunately, a few nodes need 6 bit per-node error codes. Only a very few nodes have so many counters. It turns out that there are about 2K total error counters in the system, which is (approximately) the maximum error heap index. The current (index,code) encoding limits the number of interfaces to around 250, since each interface has two associated graph nodes and we have about 500 "normal, interior" graph node This patch adds an error-index to node-index map, so we can store error heap indices directly in the vlib_buffer_t. Type: refactor Change-Id: I28101cad3d8750819e27b8785fc0cf71ff54f79a Signed-off-by: Dave Barach <dave@barachs.net> (cherry picked from commit 687c9021fda009caa2b7eb17bea2eaa51d275bde)
Diffstat (limited to 'src/plugins')
-rw-r--r--src/plugins/map/map.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/plugins/map/map.c b/src/plugins/map/map.c
index c2e821aa2e0..30031974b40 100644
--- a/src/plugins/map/map.c
+++ b/src/plugins/map/map.c
@@ -1098,7 +1098,7 @@ map_error_counter_get (u32 node_index, map_error_t map_error)
vlib_node_t *n = vlib_get_node (vm, node_index);
u32 ci;
- ci = vlib_error_get_code (e);
+ ci = vlib_error_get_code (&vm->node_main, e);
ASSERT (ci < n->n_errors);
ci += n->error_heap_index;