aboutsummaryrefslogtreecommitdiffstats
path: root/src/svm
diff options
context:
space:
mode:
authorjaszha03 <jason.zhang2@arm.com>2019-06-12 16:01:19 -0500
committerDave Barach <openvpp@barachs.net>2019-07-30 16:22:03 +0000
commitf25e7cfa5c615e1972d5823b65ca579f951d68a5 (patch)
tree47c4e91b45710d861081d1933e2e8cbe3f56fe42 /src/svm
parent6b03ab73116a7746f9480ea00c3924dcecb2799f (diff)
vppinfra: refactor use of CLIB_MEMORY_BARRIER ()
All instances of test_and_set locks used the following sequence to release the locks: CLIB_MEMORY_BARRIER (); p->lock = 0; // p is a generic struct with a TAS lock Use clib_atomic_release to generate more efficient assembly code. Type: refactor Change-Id: Idca3a38b1cf43578108bdd1afe83b6ebc17a4c68 Signed-off-by: Jason Zhang <jason.zhang2@arm.com> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> Reviewed-by: Lijian Zhang <Lijian.Zhang@arm.com>
Diffstat (limited to 'src/svm')
-rw-r--r--src/svm/ssvm.h6
1 files changed, 2 insertions, 4 deletions
diff --git a/src/svm/ssvm.h b/src/svm/ssvm.h
index 6c679456bff..60e0cc61ca4 100644
--- a/src/svm/ssvm.h
+++ b/src/svm/ssvm.h
@@ -128,8 +128,7 @@ ssvm_unlock (ssvm_shared_header_t * h)
{
h->owner_pid = 0;
h->tag = 0;
- CLIB_MEMORY_BARRIER ();
- h->lock = 0;
+ clib_atomic_release (&h->lock);
}
}
@@ -137,8 +136,7 @@ always_inline void
ssvm_unlock_non_recursive (ssvm_shared_header_t * h)
{
h->tag = 0;
- CLIB_MEMORY_BARRIER ();
- h->lock = 0;
+ clib_atomic_release (&h->lock);
}
static inline void *