summaryrefslogtreecommitdiffstats
path: root/src/vat/main.c
diff options
context:
space:
mode:
authorJon Loeliger <jdl@netgate.com>2017-09-28 13:54:16 -0500
committerNeale Ranns <nranns@cisco.com>2017-10-03 10:15:53 +0000
commit35ffa3e8f6b032f6e324234d495f769049d8feea (patch)
tree877225cf1f8997501e2dd1efdaf011fdedb7d95f /src/vat/main.c
parente2efd12b8418558cd8e701368287860409e8d265 (diff)
Propagate duplicate IF addr add/del error up to API.
Identify and complain when the same IP prefix is assigned to two different SW interfaces: vpp# set int ip address TenGigabitEthernet6/0/0 1.2.3.4/32 vpp# set int ip address TenGigabitEthernet6/0/1 1.2.3.4/32 set interface ip address: Prefix 1.2.3.4/32 already found on interface TenGigabitEthernet6/0/0 Change-Id: I1aee1b6a7ddd00d3109a53d8e1b6ce97bf45e372 Signed-off-by: Jon Loeliger <jdl@netgate.com>
Diffstat (limited to 'src/vat/main.c')
0 files changed, 0 insertions, 0 deletions
='n138' href='#n138'>138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 
/*
 * Copyright (c) 2019 Cisco and/or its affiliates.
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at:
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

#include <vnet/vnet.h>
#include <vppinfra/vec.h>
#include <vppinfra/format.h>
#include <vlib/unix/cj.h>
#include <assert.h>

#include <vnet/ip/ip.h>
#include <vnet/ethernet/ethernet.h>
#include <vnet/ethernet/arp_packet.h>
#include <vnet/vxlan/vxlan.h>
#include <dpdk/device/dpdk.h>

#include <dpdk/device/dpdk_priv.h>
#include <vppinfra/error.h>

/* constant structs */
static const struct rte_flow_attr ingress = {.ingress = 1 };

static int
dpdk_flow_add (dpdk_device_t * xd, vnet_flow_t * f, dpdk_flow_entry_t * fe)
{
  struct rte_flow_item_ipv4 ip4[2] = { };
  struct rte_flow_item_ipv4 inner_ip4[2] = { };
  struct rte_flow_item_ipv6 ip6[2] = { };
  struct rte_flow_item_ipv6 inner_ip6[2] = { };
  struct rte_flow_item_udp udp[2] = { };
  struct rte_flow_item_tcp tcp[2] = { };
  struct rte_flow_item_gtp gtp[2] = { };
  struct rte_flow_action_mark mark = { 0 };
  struct rte_flow_action_queue queue = { 0 };
  struct rte_flow_item *item, *items = 0;
  struct rte_flow_action *action, *actions = 0;
  bool fate = false;

  enum
  {
    vxlan_hdr_sz = sizeof (vxlan_header_t),
    raw_sz = sizeof (struct rte_flow_item_raw)
  };

  union
  {
    struct rte_flow_item_raw item;
    u8 val[raw_sz + vxlan_hdr_sz];
  } raw[2];

  u16 src_port, dst_port, src_port_mask, dst_port_mask;
  u8 protocol;
  int rv = 0;

  if (f->actions & (~xd->supported_flow_actions))
    return VNET_FLOW_ERROR_NOT_SUPPORTED;

  /* Match items */
  /* Ethernet */
  vec_add2 (items, item, 1);
  item->type = RTE_FLOW_ITEM_TYPE_ETH;
  item->spec = NULL;
  item->mask = NULL;

  /* VLAN */
  if ((f->type == VNET_FLOW_TYPE_IP4_N_TUPLE) ||
      (f->type == VNET_FLOW_TYPE_IP6_N_TUPLE))
    {
      vec_add2 (items, item, 1);
      item->type = RTE_FLOW_ITEM_TYPE_VLAN;
      item->spec = NULL;
      item->mask = NULL;
    }

  /* IP */
  vec_add2 (items, item, 1);
  if ((f->type == VNET_FLOW_TYPE_IP6_N_TUPLE) ||
      (f->type == VNET_FLOW_TYPE_IP6_GTPC) ||
      (f->type == VNET_FLOW_TYPE_IP6_GTPU) ||
      (f->type == VNET_FLOW_TYPE_IP6_GTPU_IP4) ||
      (f->type == VNET_FLOW_TYPE_IP6_GTPU_IP6))
    {
      vnet_flow_ip6_n_tuple_t *t6 = &f->ip6_n_tuple;
      item->type = RTE_FLOW_ITEM_TYPE_IPV6;

      if (!clib_memcmp (&t6->src_addr.mask, &zero_addr, 16) &&
	  !clib_memcmp (&t6->dst_addr.mask, &zero_addr, 16))
	{
	  item->spec = NULL;
	  item->mask = NULL;
	}
      else
	{
	  clib_memcpy_fast (ip6[0].hdr.src_addr, &t6->src_addr.addr, 16);
	  clib_memcpy_fast (ip6[1].hdr.src_addr, &t6->src_addr.mask, 16);
	  clib_memcpy_fast (ip6[0].hdr.dst_addr, &t6->dst_addr.addr, 16);
	  clib_memcpy_fast (ip6[1].hdr.dst_addr, &t6->dst_addr.mask, 16);
	  item->spec = ip6;
	  item->mask = ip6 + 1;
	}

      src_port = t6->src_port.port;
      dst_port = t6->dst_port.port;
      src_port_mask = t6->src_port.mask;
      dst_port_mask = t6->dst_port.mask;
      protocol = t6->protocol;
    }
  else if ((f->type == VNET_FLOW_TYPE_IP4_N_TUPLE) ||
	   (f->type == VNET_FLOW_TYPE_IP4_GTPC) ||
	   (f->type == VNET_FLOW_TYPE_IP4_GTPU) ||
	   (f->type == VNET_FLOW_TYPE_IP4_GTPU_IP4) ||
	   (f->type == VNET_FLOW_TYPE_IP4_GTPU_IP6))
    {
      vnet_flow_ip4_n_tuple_t *t4 = &f->ip4_n_tuple;
      item->type = RTE_FLOW_ITEM_TYPE_IPV4;

      if (!t4->src_addr.mask.as_u32 && !t4->dst_addr.mask.as_u32)
	{
	  item->spec = NULL;
	  item->mask = NULL;
	}
      else
	{
	  ip4[0].hdr.src_addr = t4->src_addr.addr.as_u32;
	  ip4[1].hdr.src_addr = t4->src_addr.mask.as_u32;
	  ip4[0].hdr.dst_addr = t4->dst_addr.addr.as_u32;
	  ip4[1].hdr.dst_addr = t4->dst_addr.mask.as_u32;
	  item->spec = ip4;
	  item->mask = ip4 + 1;
	}

      src_port = t4->src_port.port;
      dst_port = t4->dst_port.port;
      src_port_mask = t4->src_port.mask;
      dst_port_mask = t4->dst_port.mask;
      protocol = t4->protocol;
    }
  else if (f->type == VNET_FLOW_TYPE_IP4_VXLAN)
    {
      vnet_flow_ip4_vxlan_t *v4 = &f->ip4_vxlan;
      ip4[0].hdr.src_addr = v4->src_addr.as_u32;
      ip4[1].hdr.src_addr = -1;
      ip4[0].hdr.dst_addr = v4->dst_addr.as_u32;
      ip4[1].hdr.dst_addr = -1;
      item->type = RTE_FLOW_ITEM_TYPE_IPV4;
      item->spec = ip4;
      item->mask = ip4 + 1;

      dst_port = v4->dst_port;
      dst_port_mask = -1;
      src_port = 0;
      src_port_mask = 0;
      protocol = IP_PROTOCOL_UDP;
    }
  else
    {
      rv = VNET_FLOW_ERROR_NOT_SUPPORTED;
      goto done;
    }

  /* Layer 4 */
  vec_add2 (items, item, 1);
  if (protocol == IP_PROTOCOL_UDP)
    {
      item->type = RTE_FLOW_ITEM_TYPE_UDP;

      if ((src_port_mask == 0) && (dst_port_mask == 0))
	{
	  item->spec = NULL;
	  item->mask = NULL;
	}
      else
	{
	  udp[0].hdr.src_port = clib_host_to_net_u16 (src_port);
	  udp[1].hdr.src_port = clib_host_to_net_u16 (src_port_mask);
	  udp[0].hdr.dst_port = clib_host_to_net_u16 (dst_port);
	  udp[1].hdr.dst_port = clib_host_to_net_u16 (dst_port_mask);
	  item->spec = udp;
	  item->mask = udp + 1;
	}
    }
  else if (protocol == IP_PROTOCOL_TCP)
    {
      item->type = RTE_FLOW_ITEM_TYPE_TCP;

      if ((src_port_mask == 0) && (dst_port_mask == 0))
	{
	  item->spec = NULL;
	  item->mask = NULL;
	}

      tcp[0].hdr.src_port = clib_host_to_net_u16 (src_port);
      tcp[1].hdr.src_port = clib_host_to_net_u16 (src_port_mask);
      tcp[0].hdr.dst_port = clib_host_to_net_u16 (dst_port);
      tcp[1].hdr.dst_port = clib_host_to_net_u16 (dst_port_mask);
      item->spec = tcp;
      item->mask = tcp + 1;
    }
  else
    {
      rv = VNET_FLOW_ERROR_NOT_SUPPORTED;
      goto done;
    }

  /* Tunnel header match */
  if (f->type == VNET_FLOW_TYPE_IP4_VXLAN)
    {
      u32 vni = f->ip4_vxlan.vni;
      vxlan_header_t spec_hdr = {
	.flags = VXLAN_FLAGS_I,
	.vni_reserved = clib_host_to_net_u32 (vni << 8)
      };
      vxlan_header_t mask_hdr = {
	.flags = 0xff,
	.vni_reserved = clib_host_to_net_u32 (((u32) - 1) << 8)
      };

      clib_memset (raw, 0, sizeof raw);
      raw[0].item.relative = 1;
      raw[0].item.length = vxlan_hdr_sz;

      clib_memcpy_fast (raw[0].val + raw_sz, &spec_hdr, vxlan_hdr_sz);
      raw[0].item.pattern = raw[0].val + raw_sz;
      clib_memcpy_fast (raw[1].val + raw_sz, &mask_hdr, vxlan_hdr_sz);
      raw[1].item.pattern = raw[1].val + raw_sz;

      vec_add2 (items, item, 1);
      item->type = RTE_FLOW_ITEM_TYPE_RAW;
      item->spec = raw;
      item->mask = raw + 1;
    }
  else if (f->type == VNET_FLOW_TYPE_IP4_GTPC)
    {
      vnet_flow_ip4_gtpc_t *gc = &f->ip4_gtpc;
      gtp[0].teid = clib_host_to_net_u32 (gc->teid);
      gtp[1].teid = ~0;

      vec_add2 (items, item, 1);
      item->type = RTE_FLOW_ITEM_TYPE_GTPC;
      item->spec = gtp;
      item->mask = gtp + 1;
    }
  else if (f->type == VNET_FLOW_TYPE_IP4_GTPU)
    {
      vnet_flow_ip4_gtpu_t *gu = &f->ip4_gtpu;
      gtp[0].teid = clib_host_to_net_u32 (gu->teid);
      gtp[1].teid = ~0;

      vec_add2 (items, item, 1);
      item->type = RTE_FLOW_ITEM_TYPE_GTPU;
      item->spec = gtp;
      item->mask = gtp + 1;
    }
  else if ((f->type == VNET_FLOW_TYPE_IP4_GTPU_IP4) ||
	   (f->type == VNET_FLOW_TYPE_IP4_GTPU_IP6))
    {
      vnet_flow_ip4_gtpu_t *gu = &f->ip4_gtpu;
      gtp[0].teid = clib_host_to_net_u32 (gu->teid);
      gtp[1].teid = ~0;

      vec_add2 (items, item, 1);
      item->type = RTE_FLOW_ITEM_TYPE_GTPU;
      item->spec = gtp;
      item->mask = gtp + 1;

      /* inner IP4 header */
      if (f->type == VNET_FLOW_TYPE_IP4_GTPU_IP4)
	{
	  vec_add2 (items, item, 1);
	  item->type = RTE_FLOW_ITEM_TYPE_IPV4;

	  vnet_flow_ip4_gtpu_ip4_t *gu4 = &f->ip4_gtpu_ip4;
	  if (!gu4->inner_src_addr.mask.as_u32 &&
	      !gu4->inner_dst_addr.mask.as_u32)
	    {
	      item->spec = NULL;
	      item->mask = NULL;
	    }
	  else
	    {
	      inner_ip4[0].hdr.src_addr = gu4->inner_src_addr.addr.as_u32;
	      inner_ip4[1].hdr.src_addr = gu4->inner_src_addr.mask.as_u32;
	      inner_ip4[0].hdr.dst_addr = gu4->inner_dst_addr.addr.as_u32;
	      inner_ip4[1].hdr.dst_addr = gu4->inner_dst_addr.mask.as_u32;
	      item->spec = inner_ip4;
	      item->mask = inner_ip4 + 1;
	    }
	}
      else if (f->type == VNET_FLOW_TYPE_IP4_GTPU_IP6)
	{
	  ip6_address_t zero_addr;
	  vnet_flow_ip4_gtpu_ip6_t *gu6 = &f->ip4_gtpu_ip6;

	  clib_memset (&zero_addr, 0, sizeof (ip6_address_t));

	  vec_add2 (items, item, 1);
	  item->type = RTE_FLOW_ITEM_TYPE_IPV6;

	  if (!clib_memcmp (&gu6->inner_src_addr.mask, &zero_addr, 16) &&
	      !clib_memcmp (&gu6->inner_dst_addr.mask, &zero_addr, 16))
	    {
	      item->spec = NULL;
	      item->mask = NULL;
	    }
	  else
	    {
	      clib_memcpy_fast (inner_ip6[0].hdr.src_addr,
				&gu6->inner_src_addr.addr, 16);
	      clib_memcpy_fast (inner_ip6[1].hdr.src_addr,
				&gu6->inner_src_addr.mask, 16);
	      clib_memcpy_fast (inner_ip6[0].hdr.dst_addr,
				&gu6->inner_dst_addr.addr, 16);
	      clib_memcpy_fast (inner_ip6[1].hdr.dst_addr,
				&gu6->inner_dst_addr.mask, 16);
	      item->spec = inner_ip6;
	      item->mask = inner_ip6 + 1;
	    }
	}
    }
  else if (f->type == VNET_FLOW_TYPE_IP6_GTPC)
    {
      vnet_flow_ip6_gtpc_t *gc = &f->ip6_gtpc;
      gtp[0].teid = clib_host_to_net_u32 (gc->teid);
      gtp[1].teid = ~0;

      vec_add2 (items, item, 1);
      item->type = RTE_FLOW_ITEM_TYPE_GTPC;
      item->spec = gtp;
      item->mask = gtp + 1;
    }
  else if (f->type == VNET_FLOW_TYPE_IP6_GTPU)
    {
      vnet_flow_ip6_gtpu_t *gu = &f->ip6_gtpu;
      gtp[0].teid = clib_host_to_net_u32 (gu->teid);
      gtp[1].teid = ~0;

      vec_add2 (items, item, 1);
      item->type = RTE_FLOW_ITEM_TYPE_GTPU;
      item->spec = gtp;
      item->mask = gtp + 1;
    }
  else if ((f->type == VNET_FLOW_TYPE_IP6_GTPU_IP4) ||
	   (f->type == VNET_FLOW_TYPE_IP6_GTPU_IP6))
    {
      vnet_flow_ip6_gtpu_t *gu = &f->ip6_gtpu;
      gtp[0].teid = clib_host_to_net_u32 (gu->teid);
      gtp[1].teid = ~0;

      vec_add2 (items, item, 1);
      item->type = RTE_FLOW_ITEM_TYPE_GTPU;
      item->spec = gtp;
      item->mask = gtp + 1;

      /* inner IP4 header */
      if (f->type == VNET_FLOW_TYPE_IP6_GTPU_IP4)
	{
	  vec_add2 (items, item, 1);
	  item->type = RTE_FLOW_ITEM_TYPE_IPV4;

	  vnet_flow_ip6_gtpu_ip4_t *gu4 = &f->ip6_gtpu_ip4;

	  if (!gu4->inner_src_addr.mask.as_u32 &&
	      !gu4->inner_dst_addr.mask.as_u32)
	    {
	      item->spec = NULL;
	      item->mask = NULL;
	    }
	  else
	    {
	      inner_ip4[0].hdr.src_addr = gu4->inner_src_addr.addr.as_u32;
	      inner_ip4[1].hdr.src_addr = gu4->inner_src_addr.mask.as_u32;
	      inner_ip4[0].hdr.dst_addr = gu4->inner_dst_addr.addr.as_u32;
	      inner_ip4[1].hdr.dst_addr = gu4->inner_dst_addr.mask.as_u32;
	      item->spec = inner_ip4;
	      item->mask = inner_ip4 + 1;
	    }
	}

      if (f->type == VNET_FLOW_TYPE_IP6_GTPU_IP6)
	{
	  ip6_address_t zero_addr;
	  vnet_flow_ip6_gtpu_ip6_t *gu6 = &f->ip6_gtpu_ip6;

	  clib_memset (&zero_addr, 0, sizeof (ip6_address_t));

	  vec_add2 (items, item, 1);
	  item->type = RTE_FLOW_ITEM_TYPE_IPV6;

	  if (!clib_memcmp (&gu6->inner_src_addr.mask, &zero_addr, 16) &&
	      !clib_memcmp (&gu6->inner_dst_addr.mask, &zero_addr, 16))
	    {
	      item->spec = NULL;
	      item->mask = NULL;
	    }
	  else
	    {
	      clib_memcpy_fast (inner_ip6[0].hdr.src_addr,
				&gu6->inner_src_addr.addr, 16);
	      clib_memcpy_fast (inner_ip6[1].hdr.src_addr,
				&gu6->inner_src_addr.mask, 16);
	      clib_memcpy_fast (inner_ip6[0].hdr.dst_addr,
				&gu6->inner_dst_addr.addr, 16);
	      clib_memcpy_fast (inner_ip6[1].hdr.dst_addr,
				&gu6->inner_dst_addr.mask, 16);
	      item->spec = inner_ip6;
	      item->mask = inner_ip6 + 1;
	    }

	}
    }

  vec_add2 (items, item, 1);
  item->type = RTE_FLOW_ITEM_TYPE_END;

  /* Actions */
  /* Only one 'fate' can be assigned */
  if (f->actions & VNET_FLOW_ACTION_REDIRECT_TO_QUEUE)
    {
      vec_add2 (actions, action, 1);
      queue.index = f->redirect_queue;
      action->type = RTE_FLOW_ACTION_TYPE_QUEUE;
      action->conf = &queue;
      fate = true;
    }
  if (f->actions & VNET_FLOW_ACTION_DROP)
    {
      vec_add2 (actions, action, 1);
      action->type = RTE_FLOW_ACTION_TYPE_DROP;
      if (fate == true)
	{
	  rv = VNET_FLOW_ERROR_INTERNAL;
	  goto done;
	}
      else
	fate = true;
    }
  if (fate == false)
    {
      vec_add2 (actions, action, 1);
      action->type = RTE_FLOW_ACTION_TYPE_PASSTHRU;
    }

  if (f->actions & VNET_FLOW_ACTION_MARK)
    {
      vec_add2 (actions, action, 1);
      mark.id = fe->mark;
      action->type = RTE_FLOW_ACTION_TYPE_MARK;
      action->conf = &mark;
    }

  vec_add2 (actions, action, 1);
  action->type = RTE_FLOW_ACTION_TYPE_END;

  rv = rte_flow_validate (xd->device_index, &ingress, items, actions,
			  &xd->last_flow_error);

  if (rv)
    {
      if (rv == -EINVAL)
	rv = VNET_FLOW_ERROR_NOT_SUPPORTED;
      else if (rv == -EEXIST)
	rv = VNET_FLOW_ERROR_ALREADY_EXISTS;
      else
	rv = VNET_FLOW_ERROR_INTERNAL;
      goto done;
    }

  fe->handle = rte_flow_create (xd->device_index, &ingress, items, actions,
				&xd->last_flow_error);

  if (!fe->handle)
    rv = VNET_FLOW_ERROR_NOT_SUPPORTED;

done:
  vec_free (items);
  vec_free (actions);
  return rv;
}

int
dpdk_flow_ops_fn (vnet_main_t * vnm, vnet_flow_dev_op_t op, u32 dev_instance,
		  u32 flow_index, uword * private_data)
{
  dpdk_main_t *dm = &dpdk_main;
  vnet_flow_t *flow = vnet_get_flow (flow_index);
  dpdk_device_t *xd = vec_elt_at_index (dm->devices, dev_instance);
  dpdk_flow_entry_t *fe;
  dpdk_flow_lookup_entry_t *fle = 0;
  int rv;

  /* recycle old flow lookup entries only after the main loop counter
     increases - i.e. previously DMA'ed packets were handled */
  if (vec_len (xd->parked_lookup_indexes) > 0 &&
      xd->parked_loop_count != dm->vlib_main->main_loop_count)
    {
      u32 *fl_index;

      vec_foreach (fl_index, xd->parked_lookup_indexes)
	pool_put_index (xd->flow_lookup_entries, *fl_index);
      vec_reset_length (xd->flow_lookup_entries);
    }

  if (op == VNET_FLOW_DEV_OP_DEL_FLOW)
    {
      fe = vec_elt_at_index (xd->flow_entries, *private_data);

      if ((rv = rte_flow_destroy (xd->device_index, fe->handle,
				  &xd->last_flow_error)))
	return VNET_FLOW_ERROR_INTERNAL;

      if (fe->mark)
	{
	  /* make sure no action is taken for in-flight (marked) packets */
	  fle = pool_elt_at_index (xd->flow_lookup_entries, fe->mark);
	  clib_memset (fle, -1, sizeof (*fle));
	  vec_add1 (xd->parked_lookup_indexes, fe->mark);
	  xd->parked_loop_count = dm->vlib_main->main_loop_count;
	}

      clib_memset (fe, 0, sizeof (*fe));
      pool_put (xd->flow_entries, fe);

      goto disable_rx_offload;
    }

  if (op != VNET_FLOW_DEV_OP_ADD_FLOW)
    return VNET_FLOW_ERROR_NOT_SUPPORTED;

  pool_get (xd->flow_entries, fe);
  fe->flow_index = flow->index;

  if (flow->actions == 0)
    {
      rv = VNET_FLOW_ERROR_NOT_SUPPORTED;
      goto done;
    }

  /* if we need to mark packets, assign one mark */
  if (flow->actions & (VNET_FLOW_ACTION_MARK |
		       VNET_FLOW_ACTION_REDIRECT_TO_NODE |
		       VNET_FLOW_ACTION_BUFFER_ADVANCE))
    {
      /* reserve slot 0 */
      if (xd->flow_lookup_entries == 0)
	pool_get_aligned (xd->flow_lookup_entries, fle,
			  CLIB_CACHE_LINE_BYTES);
      pool_get_aligned (xd->flow_lookup_entries, fle, CLIB_CACHE_LINE_BYTES);
      fe->mark = fle - xd->flow_lookup_entries;

      /* install entry in the lookup table */
      clib_memset (fle, -1, sizeof (*fle));
      if (flow->actions & VNET_FLOW_ACTION_MARK)
	fle->flow_id = flow->mark_flow_id;
      if (flow->actions & VNET_FLOW_ACTION_REDIRECT_TO_NODE)
	fle->next_index = flow->redirect_device_input_next_index;
      if (flow->actions & VNET_FLOW_ACTION_BUFFER_ADVANCE)
	fle->buffer_advance = flow->buffer_advance;
    }
  else
    fe->mark = 0;

  if ((xd->flags & DPDK_DEVICE_FLAG_RX_FLOW_OFFLOAD) == 0)
    {
      xd->flags |= DPDK_DEVICE_FLAG_RX_FLOW_OFFLOAD;
      dpdk_device_setup (xd);
    }

  switch (flow->type)
    {
    case VNET_FLOW_TYPE_IP4_N_TUPLE:
    case VNET_FLOW_TYPE_IP6_N_TUPLE:
    case VNET_FLOW_TYPE_IP4_VXLAN:
    case VNET_FLOW_TYPE_IP4_GTPC:
    case VNET_FLOW_TYPE_IP4_GTPU:
    case VNET_FLOW_TYPE_IP4_GTPU_IP4:
    case VNET_FLOW_TYPE_IP4_GTPU_IP6:
    case VNET_FLOW_TYPE_IP6_GTPC:
    case VNET_FLOW_TYPE_IP6_GTPU:
    case VNET_FLOW_TYPE_IP6_GTPU_IP4:
    case VNET_FLOW_TYPE_IP6_GTPU_IP6:
      if ((rv = dpdk_flow_add (xd, flow, fe)))
	goto done;
      break;
    default:
      rv = VNET_FLOW_ERROR_NOT_SUPPORTED;
      goto done;
    }

  *private_data = fe - xd->flow_entries;

done:
  if (rv)
    {
      clib_memset (fe, 0, sizeof (*fe));
      pool_put (xd->flow_entries, fe);
      if (fle)
	{
	  clib_memset (fle, -1, sizeof (*fle));
	  pool_put (xd->flow_lookup_entries, fle);
	}
    }
disable_rx_offload:
  if ((xd->flags & DPDK_DEVICE_FLAG_RX_FLOW_OFFLOAD) != 0
      && pool_elts (xd->flow_entries) == 0)
    {
      xd->flags &= ~DPDK_DEVICE_FLAG_RX_FLOW_OFFLOAD;
      dpdk_device_setup (xd);
    }

  return rv;
}

u8 *
format_dpdk_flow (u8 * s, va_list * args)
{
  u32 dev_instance = va_arg (*args, u32);
  u32 flow_index = va_arg (*args, u32);
  uword private_data = va_arg (*args, uword);
  dpdk_main_t *dm = &dpdk_main;
  dpdk_device_t *xd = vec_elt_at_index (dm->devices, dev_instance);
  dpdk_flow_entry_t *fe;

  if (flow_index == ~0)
    {
      s = format (s, "%-25s: %U\n", "supported flow actions",
		  format_flow_actions, xd->supported_flow_actions);
      s = format (s, "%-25s: %d\n", "last DPDK error type",
		  xd->last_flow_error.type);
      s = format (s, "%-25s: %s\n", "last DPDK error message",
		  xd->last_flow_error.message ? xd->last_flow_error.message :
		  "n/a");
      return s;
    }

  if (private_data >= vec_len (xd->flow_entries))
    return format (s, "unknown flow");

  fe = vec_elt_at_index (xd->flow_entries, private_data);
  s = format (s, "mark %u", fe->mark);
  return s;
}

/*
 * fd.io coding-style-patch-verification: ON
 *
 * Local Variables:
 * eval: (c-set-style "gnu")
 * End:
 */