diff options
| author |   Dave Barach <dave@barachs.net> | 2019-07-23 10:22:31 -0400 |
|---|---|---|
| committer |   Florin Coras <florin.coras@gmail.com> | 2019-07-23 17:02:04 +0000 |
| commit | 687c9021fda009caa2b7eb17bea2eaa51d275bde (patch) | |
| tree | f4b1ab097c40477a847d902430abdea5bf31acc3 /src/vlib/node.c | |
| parent | 3b7261978ee4ffdc1e92336e708ae05e2be25f71 (diff) | |
vlib: address vlib_error_t scaling issue
Encoding the vpp node index into the vlib_error_t as a 10-bit quantity
limits us to 1K graph nodes. Unfortunately, a few nodes need 6 bit
per-node error codes. Only a very few nodes have so many counters.
It turns out that there are about 2K total error counters in the system,
which is (approximately) the maximum error heap index.
The current (index,code) encoding limits the number of interfaces to
around 250, since each interface has two associated graph nodes and we
have about 500 "normal, interior" graph node
This patch adds an error-index to node-index map, so we can store
error heap indices directly in the vlib_buffer_t.
Type: refactor
Change-Id: I28101cad3d8750819e27b8785fc0cf71ff54f79a
Signed-off-by: Dave Barach <dave@barachs.net>
Diffstat (limited to 'src/vlib/node.c')
| -rw-r--r-- | src/vlib/node.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/vlib/node.c b/src/vlib/node.c index 44a3a3ee25d..0e6038d01fa 100644 --- a/src/vlib/node.c +++ b/src/vlib/node.c @@ -502,7 +502,7 @@ register_node (vlib_main_t * vm, vlib_node_registration_t * r) vec_resize (rt->errors, r->n_errors); for (i = 0; i < vec_len (rt->errors); i++) - rt->errors[i] = vlib_error_set (n->index, i); + rt->errors[i] = n->error_heap_index + i; STATIC_ASSERT_SIZEOF (vlib_node_runtime_t, 128); ASSERT (vec_len (n->runtime_data) <= VLIB_NODE_RUNTIME_DATA_SIZE); |