diff options
| author |   Dave Barach <dave@barachs.net> | 2020-02-11 10:29:13 -0500 |
|---|---|---|
| committer |   Damjan Marion <dmarion@me.com> | 2020-02-11 23:11:58 +0000 |
| commit | a6ef36b2c25de47824a1b45e147ab2fbf67c3a33 (patch) | |
| tree | 01f29603e11b22763a1a539db10975171ad29f00 /src/vlib/unix/cli.c | |
| parent | 44476c6b271bdebb7458590398b5f140c9a7d353 (diff) | |
misc: fix coverity warnings
Type: fix
Ticket: VPP-1837
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I6b1ea13fc83460bf4ee75cb9249d83dddaa64ded
Diffstat (limited to 'src/vlib/unix/cli.c')
| -rw-r--r-- | src/vlib/unix/cli.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/src/vlib/unix/cli.c b/src/vlib/unix/cli.c index 0a8041e4ac4..b0ed9d2db14 100644 --- a/src/vlib/unix/cli.c +++ b/src/vlib/unix/cli.c @@ -3089,9 +3089,11 @@ unix_cli_config (vlib_main_t * vm, unformat_input_t * input) clib_panic ("sigaction"); /* Retrieve the current terminal size */ - ioctl (STDIN_FILENO, TIOCGWINSZ, &ws); - cf->width = ws.ws_col; - cf->height = ws.ws_row; + if (ioctl (STDIN_FILENO, TIOCGWINSZ, &ws) == 0) + { + cf->width = ws.ws_col; + cf->height = ws.ws_row; + } if (cf->width == 0 || cf->height == 0) { @@ -3328,7 +3330,7 @@ unix_cli_exec (vlib_main_t * vm, unformat_free (&sub_input); done: - if (fd > 0) + if (fd >= 0) close (fd); vec_free (file_name); |