summaryrefslogtreecommitdiffstats
path: root/src/vlib
diff options
context:
space:
mode:
authorMohammed Hawari <mohammed@hawari.fr>2020-10-21 16:41:30 +0200
committerDamjan Marion <dmarion@me.com>2020-10-22 15:48:14 +0000
commit70fc36f26855fb4c7a56c5d1563d541b395f8f5d (patch)
tree43ff9907967c3153b3965cd79b22f02ea44b315a /src/vlib
parent8950c272550098c544976668a943b7a5bd05de91 (diff)
pci: set PCI memory enable before mapping PCI BAR
This change mitigates software faults issued by some versions of the linux kernel vfio-pci driver when VF PCI BARs are used without setting the memory enable bit in the PCI configuration. This problem is mentionned in https://lkml.org/lkml/2020/6/25/628 Change-Id: Idc177be4a5adb6ee467b4dd8f055f133ff267fe1 Type: improvement Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
Diffstat (limited to 'src/vlib')
-rw-r--r--src/vlib/linux/pci.c12
1 files changed, 12 insertions, 0 deletions
diff --git a/src/vlib/linux/pci.c b/src/vlib/linux/pci.c
index 6078be2537e..1caf0c9c229 100644
--- a/src/vlib/linux/pci.c
+++ b/src/vlib/linux/pci.c
@@ -1134,9 +1134,21 @@ vlib_pci_map_region_int (vlib_main_t * vm, vlib_pci_dev_handle_t h,
clib_error_t *error;
int flags = MAP_SHARED;
u64 size = 0, offset = 0;
+ u16 command;
pci_log_debug (vm, p, "map region %u to va %p", bar, addr);
+ if ((error = vlib_pci_read_config_u16 (vm, h, 4, &command)))
+ return error;
+
+ if (!(command & PCI_COMMAND_MEMORY))
+ {
+ pci_log_debug (vm, p, "setting memory enable bit");
+ command |= PCI_COMMAND_MEMORY;
+ if ((error = vlib_pci_write_config_u16 (vm, h, 4, &command)))
+ return error;
+ }
+
if ((error = vlib_pci_region (vm, h, bar, &fd, &size, &offset)))
return error;