api: remove garbage from sockclnt_create reply

The fix uses memset to zero after alloc,
as sizing of source string is not obvious.

Function vl_msg_api_alloc_zero is added (and used),
so similar bugs can be fixed easily.

Type: fix
Ticket: VPP-1716

Change-Id: I3b20040d0de4222686c58779f2c0af78c5543504
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

1 files changed, 20 insertions, 0 deletions

diff --git a/src/vlibmemory/memory_shared.c b/src/vlibmemory/memory_shared.c
index 703db9da4ec..fa9936982ee 100644
--- a/src/vlibmemory/memory_shared.c
+++ b/src/vlibmemory/memory_shared.c
@@ -209,6 +209,16 @@ vl_msg_api_alloc (int nbytes)
 }
 
 void *
+vl_msg_api_alloc_zero (int nbytes)
+{
+  void *ret;
+
+  ret = vl_msg_api_alloc (nbytes);
+  clib_memset (ret, 0, nbytes);
+  return ret;
+}
+
+void *
 vl_msg_api_alloc_or_null (int nbytes)
 {
   int pool;
@@ -226,6 +236,16 @@ vl_msg_api_alloc_as_if_client (int nbytes)
 }
 
 void *
+vl_msg_api_alloc_zero_as_if_client (int nbytes)
+{
+  void *ret;
+
+  ret = vl_msg_api_alloc_as_if_client (nbytes);
+  clib_memset (ret, 0, nbytes);
+  return ret;
+}
+
+void *
 vl_msg_api_alloc_as_if_client_or_null (int nbytes)
 {
   return vl_msg_api_alloc_internal (nbytes, 0, 1 /* may_return_null */ );