summaryrefslogtreecommitdiffstats
path: root/src/vnet/adj/adj_mcast.c
diff options
context:
space:
mode:
authorBenoît Ganne <bganne@cisco.com>2019-07-18 17:34:28 +0200
committerNeale Ranns <nranns@cisco.com>2019-09-23 09:14:52 +0000
commit138c37af5291e2045075052a4db036be03be4a85 (patch)
tree9023316926f0f62fad94680e31547c07aee08aae /src/vnet/adj/adj_mcast.c
parentd51880c5de3a1b22d9ac510305bdfe98fa12e51c (diff)
fib: do not dump no-longer valid adjacencies
In some cases, we can refer to no-longer adjacencies (eg. in traces). Do not dump them in this case as they are probably incorrect (memory can be reused). Type: fix Change-Id: Ib653ba066bb6595ec6ec37d313a3124bce0eeed3 Signed-off-by: Benoît Ganne <bganne@cisco.com>
Diffstat (limited to 'src/vnet/adj/adj_mcast.c')
-rw-r--r--src/vnet/adj/adj_mcast.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/src/vnet/adj/adj_mcast.c b/src/vnet/adj/adj_mcast.c
index 4454afec630..c94d28e8713 100644
--- a/src/vnet/adj/adj_mcast.c
+++ b/src/vnet/adj/adj_mcast.c
@@ -329,7 +329,12 @@ format_adj_mcast (u8* s, va_list *ap)
{
index_t index = va_arg(*ap, index_t);
CLIB_UNUSED(u32 indent) = va_arg(*ap, u32);
- ip_adjacency_t * adj = adj_get(index);
+ ip_adjacency_t * adj;
+
+ if (!adj_is_valid(index))
+ return format(s, "<invalid adjacency>");
+
+ adj = adj_get(index);
s = format(s, "%U-mcast: ",
format_fib_protocol, adj->ia_nh_proto);