summaryrefslogtreecommitdiffstats
path: root/src/vnet/devices/virtio/tap.c
diff options
context:
space:
mode:
authorSteven <sluong@cisco.com>2017-11-30 16:56:54 -0800
committerDamjan Marion <dmarion.lists@gmail.com>2017-12-01 11:14:52 +0000
commitf953dfc8e01426ce93588e9013c112e48a9a8463 (patch)
treedd5e7eb09511df669dc9bec6a1cbf0300df3c344 /src/vnet/devices/virtio/tap.c
parent088f0e221c05b7b1cd59b61442eaf595e22e2fef (diff)
virtio: fix coverity warnings
Fix 3 coverity warnings 1. api_format.c: init net_ns = 0 and remove its corresponding vec_add and vec_free 2. netlink.c (reported in tap.c before the code was removed): resource leaked due to fd is not close 3. tap.c: subtract 1 for size when calling strncpy to accommodate the terminated NULL character Change-Id: Iff4e66604862f0c06dac227b8cfd48d3979e41a5 Signed-off-by: Steven <sluong@cisco.com>
Diffstat (limited to 'src/vnet/devices/virtio/tap.c')
-rw-r--r--src/vnet/devices/virtio/tap.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/vnet/devices/virtio/tap.c b/src/vnet/devices/virtio/tap.c
index f6db2c90616..34339c95737 100644
--- a/src/vnet/devices/virtio/tap.c
+++ b/src/vnet/devices/virtio/tap.c
@@ -109,7 +109,7 @@ tap_create_if (vlib_main_t * vm, tap_create_if_args_t * args)
}
ifr.ifr_flags = IFF_TAP | IFF_NO_PI | IFF_ONE_QUEUE | IFF_VNET_HDR;
- strncpy (ifr.ifr_ifrn.ifrn_name, (char *) args->name, IF_NAMESIZE);
+ strncpy (ifr.ifr_ifrn.ifrn_name, (char *) args->name, IF_NAMESIZE - 1);
_IOCTL (vif->tap_fd, TUNSETIFF, (void *) &ifr);
vif->ifindex = if_nametoindex ((char *) args->name);