diff options
| author |   Benoît Ganne <bganne@cisco.com> | 2019-02-12 13:35:08 +0100 |
|---|---|---|
| committer |   Damjan Marion <dmarion@me.com> | 2019-02-14 17:18:36 +0000 |
| commit | 47727c02df4c79c21c6ceffaff65222c32cf6996 (patch) | |
| tree | ff56da0094b29da6d07746b08574dfb194ed9113 /src/vnet/devices | |
| parent | 8f6c1dda355b6e4d00dc4e41e65a25e1fd1507ee (diff) | |
Add -fno-common compile option
-fno-common makes sure we do not have multiple declarations of the same
global symbol across compilation units. It helps debug nasty linkage
bugs by guaranteeing that all reference to a global symbol use the same
underlying object.
It also helps avoiding benign mistakes such as declaring enum as global
objects instead of types in headers (hence the minor fixes scattered
across the source).
Change-Id: I55c16406dc54ff8a6860238b90ca990fa6b179f1
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Diffstat (limited to 'src/vnet/devices')
| -rw-r--r-- | src/vnet/devices/pipe/pipe_api.c | 2 | ||||
| -rw-r--r-- | src/vnet/devices/virtio/vhost_user_input.c | 2 | ||||
| -rw-r--r-- | src/vnet/devices/virtio/vhost_user_output.c | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/src/vnet/devices/pipe/pipe_api.c b/src/vnet/devices/pipe/pipe_api.c index cb67d1f0404..1dcb8bc76c6 100644 --- a/src/vnet/devices/pipe/pipe_api.c +++ b/src/vnet/devices/pipe/pipe_api.c @@ -36,7 +36,7 @@ #undef vl_printfun #include <vlibapi/api_helper_macros.h> -vpe_api_main_t vpe_api_main; +extern vpe_api_main_t vpe_api_main; #define foreach_vpe_api_msg \ _(PIPE_CREATE, pipe_create) \ diff --git a/src/vnet/devices/virtio/vhost_user_input.c b/src/vnet/devices/virtio/vhost_user_input.c index 3c3d48e9ef4..286fa7ed744 100644 --- a/src/vnet/devices/virtio/vhost_user_input.c +++ b/src/vnet/devices/virtio/vhost_user_input.c @@ -65,7 +65,7 @@ */ #define VHOST_USER_RX_COPY_THRESHOLD 64 -vlib_node_registration_t vhost_user_input_node; +extern vlib_node_registration_t vhost_user_input_node; #define foreach_vhost_user_input_func_error \ _(NO_ERROR, "no error") \ diff --git a/src/vnet/devices/virtio/vhost_user_output.c b/src/vnet/devices/virtio/vhost_user_output.c index 4fbd63ea708..c0c54d1b13a 100644 --- a/src/vnet/devices/virtio/vhost_user_output.c +++ b/src/vnet/devices/virtio/vhost_user_output.c @@ -53,7 +53,7 @@ */ #define VHOST_USER_TX_COPY_THRESHOLD (VHOST_USER_COPY_ARRAY_N - 40) -vnet_device_class_t vhost_user_device_class; +extern vnet_device_class_t vhost_user_device_class; #define foreach_vhost_user_tx_func_error \ _(NONE, "no error") \ |