diff options
| author |   Dave Barach <dave@barachs.net> | 2020-02-17 09:13:26 -0500 |
|---|---|---|
| committer |   Andrew Yourtchenko <ayourtch@gmail.com> | 2020-08-12 15:59:46 +0000 |
| commit | 18d2d6bd4a2c968707e912356a0ee02496fba2fc (patch) | |
| tree | 47d60d947c26ed3538366b88fcb327fe8377d9a4 /src/vnet/dpo | |
| parent | 84918d25541ee1173beda281554544cd168b7e65 (diff) | |
misc: fix coverity warnings
Add an ALWAYS_ASSERT (...) macro, to (a) shut up coverity, and (b)
check the indicated condition in production images.
As in:
p = hash_get(...);
ALWAYS_ASSERT(p) /* was ASSERT(p) */
elt = pool_elt_at_index(pool, p[0]);
This may not be the best way to handle a specific case, but failure to
check return values at all followed by e.g. a pointer dereference
isn't ok.
Type: fix
Ticket: VPP-1837
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Ia97c641cefcfb7ea7d77ea5a55ed4afea0345acb
(cherry picked from commit 47d41ad62c5d6008e72d2e9c137cf8f49ca86353)
Diffstat (limited to 'src/vnet/dpo')
| -rw-r--r-- | src/vnet/dpo/load_balance_map.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/vnet/dpo/load_balance_map.c b/src/vnet/dpo/load_balance_map.c index bf5d1fb2943..7da360b88ac 100644 --- a/src/vnet/dpo/load_balance_map.c +++ b/src/vnet/dpo/load_balance_map.c @@ -274,7 +274,7 @@ load_balance_map_db_remove (load_balance_map_t *lbm) { p = hash_get(lb_maps_by_path_index, lbmp->lbmp_index); - ASSERT(NULL != p); + ALWAYS_ASSERT(NULL != p); fib_node_list_remove(p[0], lbmp->lbmp_sibling); } @@ -312,7 +312,7 @@ load_balance_map_fill (load_balance_map_t *lbm) tmp_buckets[jj++] = bucket++; } } - else + else { bucket += lbmp->lbmp_weight; } |