diff options
| author |   Dave Barach <dave@barachs.net> | 2020-02-17 09:13:26 -0500 |
|---|---|---|
| committer |   Florin Coras <florin.coras@gmail.com> | 2020-02-17 17:18:18 +0000 |
| commit | 47d41ad62c5d6008e72d2e9c137cf8f49ca86353 (patch) | |
| tree | a21f871a26f97c6a47fbfbae4b4d67f27c6036f5 /src/vnet/fib/fib_attached_export.c | |
| parent | a316744bc5e003d0fa4c8aff82c619b300115f02 (diff) | |
misc: fix coverity warnings
Add an ALWAYS_ASSERT (...) macro, to (a) shut up coverity, and (b)
check the indicated condition in production images.
As in:
p = hash_get(...);
ALWAYS_ASSERT(p) /* was ASSERT(p) */
elt = pool_elt_at_index(pool, p[0]);
This may not be the best way to handle a specific case, but failure to
check return values at all followed by e.g. a pointer dereference
isn't ok.
Type: fix
Ticket: VPP-1837
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Ia97c641cefcfb7ea7d77ea5a55ed4afea0345acb
Diffstat (limited to 'src/vnet/fib/fib_attached_export.c')
| -rw-r--r-- | src/vnet/fib/fib_attached_export.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/vnet/fib/fib_attached_export.c b/src/vnet/fib/fib_attached_export.c index 3c9c2bffee6..4a33b8897f5 100644 --- a/src/vnet/fib/fib_attached_export.c +++ b/src/vnet/fib/fib_attached_export.c @@ -364,7 +364,7 @@ fib_attached_export_purge (fib_entry_t *fib_entry) fed = fib_entry_delegate_find(export_entry, FIB_ENTRY_DELEGATE_ATTACHED_EXPORT); - ASSERT(NULL != fed); + ALWAYS_ASSERT(NULL != fed); export = pool_elt_at_index(fib_ae_export_pool, fed->fd_index); @@ -391,7 +391,7 @@ fib_attached_export_purge (fib_entry_t *fib_entry) pool_put(fib_ae_import_pool, import); fib_entry_delegate_remove(fib_entry, FIB_ENTRY_DELEGATE_ATTACHED_IMPORT); - } + } } void @@ -522,7 +522,7 @@ fib_ae_import_format (fib_node_index_t impi, s = format(s, "export-sibling:%d ", import->faei_export_sibling); s = format(s, "exporter:%d ", import->faei_exporter); s = format(s, "export-fib:%d ", import->faei_export_fib); - + s = format(s, "import-entry:%d ", import->faei_import_entry); s = format(s, "import-fib:%d ", import->faei_import_fib); @@ -544,7 +544,7 @@ fib_ae_export_format (fib_node_index_t expi, fib_ae_export_t *export; export = pool_elt_at_index(fib_ae_export_pool, expi); - + s = format(s, "\n Attached-Export:%d:[", (export - fib_ae_export_pool)); s = format(s, "export-entry:%d ", export->faee_ei); |