diff options
| author |   Neale Ranns <nranns@cisco.com> | 2019-07-16 15:28:52 +0000 |
|---|---|---|
| committer |   Dave Barach <openvpp@barachs.net> | 2019-07-19 21:46:36 +0000 |
| commit | 1f50bf8fc57ebf78f9056185a342493be460a847 (patch) | |
| tree | 55bcf7508dc679b9a38552438d21b8b1fa05331e /src/vnet/fib/fib_entry_cover.c | |
| parent | cca9618a5e1b126263ef262974b0b4d6ac6352a2 (diff) | |
fib: FIB Entry tracking
Instead of all clients directly RR sourcing the entry they are tracking,
use a deidcated 'tracker' object. This tracker object is a entry
delegate and a child of the entry. The clients are then children of the
tracker.
The benefit of this aproach is that each time a new client tracks the
entry it doesn't RR source it. When an entry is sourced all its children
are updated. Thus, new clients tracking an entry is O(n^2). With the
tracker as indirection, the entry is sourced only once.
Type: feature
Change-Id: I5b80bdda6c02057152e5f721e580e786cd840a3b
Signed-off-by: Neale Ranns <nranns@cisco.com>
Diffstat (limited to 'src/vnet/fib/fib_entry_cover.c')
| -rw-r--r-- | src/vnet/fib/fib_entry_cover.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/src/vnet/fib/fib_entry_cover.c b/src/vnet/fib/fib_entry_cover.c index c7308224f0a..153bd70a5bf 100644 --- a/src/vnet/fib/fib_entry_cover.c +++ b/src/vnet/fib/fib_entry_cover.c @@ -16,6 +16,7 @@ #include <vnet/fib/fib_entry_cover.h> #include <vnet/fib/fib_entry_src.h> #include <vnet/fib/fib_node_list.h> +#include <vnet/fib/fib_entry_delegate.h> u32 fib_entry_cover_track (fib_entry_t* cover, @@ -27,7 +28,7 @@ fib_entry_cover_track (fib_entry_t* cover, ASSERT(fib_entry_get_index(cover) != covered); - fed = fib_entry_delegate_get(cover, FIB_ENTRY_DELEGATE_COVERED); + fed = fib_entry_delegate_find(cover, FIB_ENTRY_DELEGATE_COVERED); if (NULL == fed) { @@ -48,7 +49,7 @@ fib_entry_cover_untrack (fib_entry_t* cover, FIB_ENTRY_DBG(cover, "cover-untrack @ %d", tracked_index); - fed = fib_entry_delegate_get(cover, FIB_ENTRY_DELEGATE_COVERED); + fed = fib_entry_delegate_find(cover, FIB_ENTRY_DELEGATE_COVERED); if (NULL == fed) return; @@ -90,7 +91,7 @@ fib_entry_cover_walk (fib_entry_t *cover, { fib_entry_delegate_t *fed; - fed = fib_entry_delegate_get(cover, FIB_ENTRY_DELEGATE_COVERED); + fed = fib_entry_delegate_find(cover, FIB_ENTRY_DELEGATE_COVERED); if (NULL == fed) return; |