diff options
| author |   Pim van Pelt <pim@ipng.nl> | 2021-08-10 23:44:44 +0200 |
|---|---|---|
| committer |   Neale Ranns <neale@graphiant.com> | 2021-08-14 12:05:39 +0000 |
| commit | 76b19ceafcf892b56a679d3d7fe5c6f4b93f7de7 (patch) | |
| tree | 947c5d5f7dba6a2abc02ac63fc1772de5b6f0f8c /src/vnet/ip/ip4_forward.c | |
| parent | 2a1783fd6ae7e17c994010fca414c180eb48bc40 (diff) | |
ip: Fix crash in ip address add on sub-int without exact-match
Type: fix
Creating a sub-int without exact-match set, and subsequently adding an
IPv4 or IPv6 address will crash VPP. This fix catches this situation and
refuses to allow the caller to add an IPv4 or IPv6 address on an
ethernet sub-int that does not have exact-match set.
TESTED:
Before this change, the following crashes VPP:
```
DBGvpp# cre sub TenGigabitEthernet3/0/0 1 dot1q 10
TenGigabitEthernet3/0/0.1
DBGvpp# set interface ip address TenGigabitEthernet3/0/0.1 2001:db8::1/64
<crash>
```
After the change, VPP refuses to act:
```
DBGvpp# cre sub TenGigabitEthernet3/0/0 1 dot1q 10
TenGigabitEthernet3/0/0.1
DBGvpp# set interface ip address TenGigabitEthernet3/0/0.1 192.0.2.1/30
set interface ip address: sub-interface without exact-match doesn't support IP addressing
DBGvpp# set interface ip address TenGigabitEthernet3/0/0.1 2001:db8:1/64
set interface ip address: sub-interface without exact-match doesn't support IP addressing
```
Signed-off-by: Pim van Pelt <pim@ipng.nl>
Change-Id: I42997db314225cd186ebb54013b5717ace7f7bd6
Diffstat (limited to 'src/vnet/ip/ip4_forward.c')
| -rw-r--r-- | src/vnet/ip/ip4_forward.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/src/vnet/ip/ip4_forward.c b/src/vnet/ip/ip4_forward.c index ea67005176f..57ad658b83f 100644 --- a/src/vnet/ip/ip4_forward.c +++ b/src/vnet/ip/ip4_forward.c @@ -653,12 +653,9 @@ ip4_add_del_interface_address_internal (vlib_main_t * vm, u32 if_address_index; ip4_address_fib_t ip4_af, *addr_fib = 0; - /* local0 interface doesn't support IP addressing */ - if (sw_if_index == 0) - { - return - clib_error_create ("local0 interface doesn't support IP addressing"); - } + error = vnet_sw_interface_supports_addressing (vnm, sw_if_index); + if (error) + return error; vec_validate (im->fib_index_by_sw_if_index, sw_if_index); ip4_addr_fib_init (&ip4_af, address, |