diff options
| author |   Klement Sekera <ksekera@cisco.com> | 2020-03-30 16:59:38 +0200 |
|---|---|---|
| committer |   Ole Trøan <otroan@employees.org> | 2020-04-06 08:59:20 +0000 |
| commit | 1766ddca4406cbfddb2878990d580a6f9e34a58e (patch) | |
| tree | e61bf109a53b8c925e1db2abc48ffbb65c171fd2 /src/vnet/ip/reass/ip4_sv_reass.c | |
| parent | 0250090fc0c24214cb1fa969f6e2f585099ee36b (diff) | |
ip: reassembly: don't set error if no error
Type: fix
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Change-Id: I9d25129fbf1ea880121b281f41750155286fb489
Diffstat (limited to 'src/vnet/ip/reass/ip4_sv_reass.c')
| -rw-r--r-- | src/vnet/ip/reass/ip4_sv_reass.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/vnet/ip/reass/ip4_sv_reass.c b/src/vnet/ip/reass/ip4_sv_reass.c index 29877cf5dfd..9b6116c9778 100644 --- a/src/vnet/ip/reass/ip4_sv_reass.c +++ b/src/vnet/ip/reass/ip4_sv_reass.c @@ -504,6 +504,7 @@ ip4_sv_reass_inline (vlib_main_t * vm, vlib_node_runtime_t * node, { next0 = IP4_SV_REASSEMBLY_NEXT_DROP; error0 = IP4_ERROR_REASS_MALFORMED_PACKET; + b0->error = node->errors[error0]; goto packet_enqueue; } ip4_sv_reass_kv_t kv; @@ -532,6 +533,7 @@ ip4_sv_reass_inline (vlib_main_t * vm, vlib_node_runtime_t * node, { next0 = IP4_SV_REASSEMBLY_NEXT_DROP; error0 = IP4_ERROR_REASS_LIMIT_REACHED; + b0->error = node->errors[error0]; goto packet_enqueue; } @@ -556,7 +558,6 @@ ip4_sv_reass_inline (vlib_main_t * vm, vlib_node_runtime_t * node, reass->tcp_seq_number; vnet_buffer (b0)->ip.reass.l4_src_port = reass->l4_src_port; vnet_buffer (b0)->ip.reass.l4_dst_port = reass->l4_dst_port; - error0 = IP4_ERROR_NONE; if (PREDICT_FALSE (b0->flags & VLIB_BUFFER_IS_TRACED)) { ip4_sv_reass_add_trace (vm, node, rm, reass, bi0, @@ -644,8 +645,6 @@ ip4_sv_reass_inline (vlib_main_t * vm, vlib_node_runtime_t * node, goto next_packet; packet_enqueue: - b0->error = node->errors[error0]; - to_next[0] = bi0; to_next += 1; n_left_to_next -= 1; |