diff options
| author |   Elias Rudberg <elias.rudberg@bahnhof.net> | 2020-05-27 01:03:46 +0200 |
|---|---|---|
| committer |   Dave Wallace <dwallacelf@gmail.com> | 2020-07-15 17:05:13 +0000 |
| commit | 49ab961abfce43e85a8c38050e28a07f01d077e0 (patch) | |
| tree | 49d7773eafd19616b470a5ca449ab7d3c98821b3 /src/vnet/ipfix-export | |
| parent | fa729ec6cd6c7e3ec8cd7b13ede3cc6665587aed (diff) | |
misc: ipfix-export unformat u16 collector_port fix
Use %U and unformat_udp_port instead of %u for unformat() call for
u16 collector_port number in set_ipfix_exporter_command_fn() to
avoid corruption of other variables which can happen if unformat()
with %u is used with a 16-bit variable. This avoids crash due to
corrupted fib_index value.
Type: fix
Signed-off-by: Elias Rudberg <elias.rudberg@bahnhof.net>
Change-Id: Id54273fcc458a7f9c5aa4025aa91711f160c1c1a
(cherry picked from commit 2dca180db989ea7afacdf4e70cc85e4408557382)
Diffstat (limited to 'src/vnet/ipfix-export')
| -rw-r--r-- | src/vnet/ipfix-export/flow_report.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/vnet/ipfix-export/flow_report.c b/src/vnet/ipfix-export/flow_report.c index d904479c9c9..012ca6eeb39 100644 --- a/src/vnet/ipfix-export/flow_report.c +++ b/src/vnet/ipfix-export/flow_report.c @@ -500,7 +500,8 @@ set_ipfix_exporter_command_fn (vlib_main_t * vm, { if (unformat (input, "collector %U", unformat_ip4_address, &collector)) ; - else if (unformat (input, "port %u", &collector_port)) + else if (unformat (input, "port %U", unformat_udp_port, + &collector_port)) ; else if (unformat (input, "src %U", unformat_ip4_address, &src)) ; |