diff options
| author |   Benoît Ganne <bganne@cisco.com> | 2019-02-12 13:35:08 +0100 |
|---|---|---|
| committer |   Damjan Marion <dmarion@me.com> | 2019-02-14 17:18:36 +0000 |
| commit | 47727c02df4c79c21c6ceffaff65222c32cf6996 (patch) | |
| tree | ff56da0094b29da6d07746b08574dfb194ed9113 /src/vnet/l2 | |
| parent | 8f6c1dda355b6e4d00dc4e41e65a25e1fd1507ee (diff) | |
Add -fno-common compile option
-fno-common makes sure we do not have multiple declarations of the same
global symbol across compilation units. It helps debug nasty linkage
bugs by guaranteeing that all reference to a global symbol use the same
underlying object.
It also helps avoiding benign mistakes such as declaring enum as global
objects instead of types in headers (hence the minor fixes scattered
across the source).
Change-Id: I55c16406dc54ff8a6860238b90ca990fa6b179f1
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Diffstat (limited to 'src/vnet/l2')
| -rw-r--r-- | src/vnet/l2/l2_learn.h | 2 | ||||
| -rw-r--r-- | src/vnet/l2/l2_patch.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/vnet/l2/l2_learn.h b/src/vnet/l2/l2_learn.h index c1071450852..58e19babc6e 100644 --- a/src/vnet/l2/l2_learn.h +++ b/src/vnet/l2/l2_learn.h @@ -52,7 +52,7 @@ extern l2learn_main_t l2learn_main; extern vlib_node_registration_t l2fib_mac_age_scanner_process_node; -enum +typedef enum { L2_MAC_AGE_PROCESS_EVENT_START = 1, L2_MAC_AGE_PROCESS_EVENT_STOP = 2, diff --git a/src/vnet/l2/l2_patch.c b/src/vnet/l2/l2_patch.c index e2d2a679662..54286c23d72 100644 --- a/src/vnet/l2/l2_patch.c +++ b/src/vnet/l2/l2_patch.c @@ -49,7 +49,7 @@ format_l2_patch_trace (u8 * s, va_list * args) return s; } -l2_patch_main_t l2_patch_main; +static l2_patch_main_t l2_patch_main; static vlib_node_registration_t l2_patch_node; |