diff options
| author |   Dave Wallace <dwallacelf@gmail.com> | 2017-10-24 01:32:41 -0400 |
|---|---|---|
| committer | Dave Wallace <dwallacelf@gmail.com> | 2017-10-24 01:32:41 -0400 |
| commit | 71612d61930e57e7c8ebf9e5647b15a4b23720b2 (patch) | |
| tree | 3c135af6d40442f5ae9f8397c62080e2b7e3f342 /src/vnet/lawful-intercept | |
| parent | 92b0275a364022af6ab828dfac83e38c0117cfe6 (diff) | |
Add extern to *_main global variable declarations in header files.
- Global variables declared in header files without
the use of the 'extern' keword will result in multiple
instances of the variable to be created by the compiler
-- one for each different source file in which the
the header file is included. This results in wasted
memory allocated in the BSS segments as well as
potentially introducing bugs in the application.
Change-Id: I6ef1790b60a0bd9dd3994f8510723decf258b0cc
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Diffstat (limited to 'src/vnet/lawful-intercept')
| -rw-r--r-- | src/vnet/lawful-intercept/lawful_intercept.c | 2 | ||||
| -rw-r--r-- | src/vnet/lawful-intercept/lawful_intercept.h | 2 |
2 files changed, 3 insertions, 1 deletions
diff --git a/src/vnet/lawful-intercept/lawful_intercept.c b/src/vnet/lawful-intercept/lawful_intercept.c index ef07a339201..e48e1cf4bd1 100644 --- a/src/vnet/lawful-intercept/lawful_intercept.c +++ b/src/vnet/lawful-intercept/lawful_intercept.c @@ -15,6 +15,8 @@ #include <vnet/lawful-intercept/lawful_intercept.h> +li_main_t li_main; + static clib_error_t * set_li_command_fn (vlib_main_t * vm, unformat_input_t * input, diff --git a/src/vnet/lawful-intercept/lawful_intercept.h b/src/vnet/lawful-intercept/lawful_intercept.h index 89e699f51a0..bcb18afece2 100644 --- a/src/vnet/lawful-intercept/lawful_intercept.h +++ b/src/vnet/lawful-intercept/lawful_intercept.h @@ -33,7 +33,7 @@ typedef struct { vnet_main_t * vnet_main; } li_main_t; -li_main_t li_main; +extern li_main_t li_main; typedef CLIB_PACKED(struct { ip4_header_t ip4; |