diff options
| author |   Dave Barach <dave@barachs.net> | 2020-04-29 17:04:10 -0400 |
|---|---|---|
| committer |   Florin Coras <florin.coras@gmail.com> | 2020-05-04 14:03:21 +0000 |
| commit | 7784140f2bd2d5ae44f2be1507ac25f102006155 (patch) | |
| tree | 4ac12e04f5177bffab6f3c05d6bf837567a65988 /src/vnet/lldp/lldp_api.c | |
| parent | d88fc0fcedb402e3dc82cb44280d4567a6a13266 (diff) | |
misc: binary api fuzz test fixes
Add a hook to src/vlibapi/api_shared.c to fuzz (screw up) binary API
messages, e.g. by xoring random data into them before processing. We
specifically exempt client connection messages, and inband debug CLI
messages. We step over msg_id, client index, client context, and
sw_if_index. Otherwise, "make test" vectors fail too rapidly to learn
anything.
The goal is to reduce the number of crashes caused to zero. We're
fairly close with this patch.
Add vl_msg_api_max_length(void *mp), which returns the maximum
plausible length for a binary API message.
Use it to hardern vl_api_from_api_to_new_vec(...) which takes an
additional argument - message pointer - so it can verify that
astr->length is sane. If it's not sane, return a u8 *vector of the
form "insane astr->length nnnn\0".
Verify array lengths in vl_api_dhcp6_send_client_message_t_handler(...)
and vl_api_dhcp6_pd_send_client_message_t_handler(...).
Add a fairly effective binary API fuzz hook to the unittest plugin,
and modify the "make test" framework.py to pass "api-fuzz { on|off }"
to enable API fuzzing: "make API_FUZZ=on TEST=xxx test-debug" or similar
Type: improvement
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I0157267652a163c01553d5267620f719cc6c3bde
Diffstat (limited to 'src/vnet/lldp/lldp_api.c')
| -rw-r--r-- | src/vnet/lldp/lldp_api.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/vnet/lldp/lldp_api.c b/src/vnet/lldp/lldp_api.c index a6d7fb84bb7..ecb75bcac4b 100644 --- a/src/vnet/lldp/lldp_api.c +++ b/src/vnet/lldp/lldp_api.c @@ -57,7 +57,7 @@ vl_api_lldp_config_t_handler (vl_api_lldp_config_t * mp) int rv = 0; u8 *sys_name = 0; - sys_name = vl_api_from_api_to_new_vec (&mp->system_name); + sys_name = vl_api_from_api_to_new_vec (mp, &mp->system_name); if (lldp_cfg_set (&sys_name, ntohl (mp->tx_hold), ntohl (mp->tx_interval)) != lldp_ok) |