api: comment, simplify and fix api socket read - vpp

diff options

author	Vratko Polak <vrpolak@cisco.com>	2019-10-07 14:52:53 +0200
committer	Ole Trøan <otroan@employees.org>	2019-10-09 09:23:50 +0000
commit	6a6af6ea1a77b5818e717047b5d01251ef6d024a (patch)
tree	0c6ffcd373601626dae4c0144467a9fb38f09f40 /src/vnet/session/application_local.h
parent	0938547eaaf5440de28877fa4f873c21bcb8cfbf (diff)

api: comment, simplify and fix api socket read

The function vl_socket_read_ready did contain some comments already, but as they stated, the logic has to be tricky to cover multiple cases. Comment: + Add function-level comment + Add comments to describe some of local variables + Add many comments to describe internal state at particular lines. Simplify: + Remov mbp_set as it is never needed. + Replace msg_len with msgbuf_len to save "+ sizeof (msgbuf_t)". Improve: + Early exit on EAGAIN. Fix: + "n" now only tracks input_buffer. Previously, it was entering the detection of additional messages even for unprocessed_input. + Set up msg_buffer (including appending to unprocessed_input) outside full-message-detection loop now, so it cannot be executed multiple times as before. Type: fix Ticket: VPP-1785 Change-Id: I256e34b435be06844458744a13ea37a0e86a96f9 Signed-off-by: Vratko Polak <vrpolak@cisco.com>

Diffstat (limited to 'src/vnet/session/application_local.h')

0 files changed, 0 insertions, 0 deletions

/* * Copyright (c) 2015 Cisco and/or its affiliates. * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at: * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ #ifndef __included_crc32_h__ #define __included_crc32_h__ #include <vppinfra/clib.h> #if __SSE4_2__ #define clib_crc32c_uses_intrinsics #include <x86intrin.h> #define crc32_u64 _mm_crc32_u64 static_always_inline u32 clib_crc32c (u8 * s, int len) { u32 v = 0; #if __x86_64__ for (; len >= 8; len -= 8, s += 8) v = _mm_crc32_u64 (v, *((u64 *) s)); #else /* workaround weird GCC bug when using _mm_crc32_u32 which happens with -O2 optimization */ volatile ("":::"memory"); #endif for (; len >= 4; len -= 4, s += 4) v = _mm_crc32_u32 (v, *((u32 *) s)); for (; len >= 2; len -= 2, s += 2) v = _mm_crc32_u16 (v, *((u16 *) s)); for (; len >= 1; len -= 1, s += 1) v = _mm_crc32_u8 (v, *((u16 *) s)); return v; } #elif __ARM_FEATURE_CRC32 #define clib_crc32c_uses_intrinsics #include <arm_acle.h> #define crc32_u64 __crc32cd static_always_inline u32 clib_crc32c (u8 * s, int len) { u32 v = 0; for (; len >= 8; len -= 8, s += 8) v = __crc32cd (v, *((u64 *) s)); for (; len >= 4; len -= 4, s += 4) v = __crc32cw (v, *((u32 *) s)); for (; len >= 2; len -= 2, s += 2) v = __crc32ch (v, *((u16 *) s)); for (; len >= 1; len -= 1, s += 1) v = __crc32cb (v, *((u8 *) s)); return v; } #endif #endif /* __included_crc32_h__ */ /* * fd.io coding-style-patch-verification: ON * * Local Variables: * eval: (c-set-style "gnu") * End: */


context:
space:
mode: